[ovs-git] Open vSwitch: ofproto-dpif: Disable miss handling in rule_get_stats(). (master)

dev at openvswitch.org dev at openvswitch.org
Sun Apr 7 01:25:57 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  4464589ee774fe4e12777e757469817744f74a93 (commit)
      from  ca03aae04af733a32b8dcfd95f38d301ecc80277 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4464589ee774fe4e12777e757469817744f74a93
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4464589ee774fe4e12777e757469817744f74a93
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto-dpif: Disable miss handling in rule_get_stats().
		
rule_get_stats() is often called when iterating over every rule in
the flow table.  To ensure up-to-date statistics, rule_get_stats()
calls push_all_stats() which can cause flow misses to be handled.
When using the learn action, this can cause rules to be added (and
potentially removed) from the OpenFlow table.  This could corrupt
the caller's data structures, leading to a segmentation fault.
This patch fixes the issue by disabling flow miss handling from
within rule_get_stats().

Bug #15999.
Signed-off-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list