[ovs-git] Open vSwitch: netdev: Minor formatting improvements. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Aug 2 19:28:12 UTC 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  15aee11695811c70efd8b7d3dab11625b4dd59f2 (commit)
       via  96172faa345dbd8763fc3b1b64319c384d0a0798 (commit)
       via  7d6ce2d189332aac67d65c73c582d57a17b7ac70 (commit)
       via  2e5ae318d522ce2cf2c6424958f27fce4f8b7ae7 (commit)
       via  f61d8d2931806eae5b25ed8bdd5ff4cf43afe776 (commit)
       via  59e0c910d043a8f91abc429925f53d34912dac09 (commit)
      from  01fcdfc6b3223d186c35d9b4e188c9e104887f4c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 15aee11695811c70efd8b7d3dab11625b4dd59f2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15aee11695811c70efd8b7d3dab11625b4dd59f2
Author: Ben Pfaff <blp at nicira.com>
netdev: Minor formatting improvements.
Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 96172faa345dbd8763fc3b1b64319c384d0a0798
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=96172faa345dbd8763fc3b1b64319c384d0a0798
Author: Ben Pfaff <blp at nicira.com>
netdev-linux: Don't assume 'struct netdev' has offset 0.
The data items returned by netdev_get_devices() are "struct netdev *"s.
The code fixed up by this commit used them as "struct netdev_linux *",
which happens to work because struct netdev happens to be at offset 0 in
each struct but it's better to do a proper cast in case someday
struct netdev gets moved to a nonzero offset.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 7d6ce2d189332aac67d65c73c582d57a17b7ac70
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7d6ce2d189332aac67d65c73c582d57a17b7ac70
Author: Ben Pfaff <blp at nicira.com>
netdev-dummy: Fix memory leak on error path in netdev_rx_dummy_recv().
This code failed to free the packet if it was too big for the caller.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 2e5ae318d522ce2cf2c6424958f27fce4f8b7ae7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2e5ae318d522ce2cf2c6424958f27fce4f8b7ae7
Author: Ben Pfaff <blp at nicira.com>
netdev-linux: Initialize change_seq for tap devices too.
change_seq is supposed to always be nonzero but tap devices got this wrong.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit f61d8d2931806eae5b25ed8bdd5ff4cf43afe776
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f61d8d2931806eae5b25ed8bdd5ff4cf43afe776
Author: Ben Pfaff <blp at nicira.com>
netdev-linux: Fix fd leak on error path.
Found by inspection.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit 59e0c910d043a8f91abc429925f53d34912dac09
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=59e0c910d043a8f91abc429925f53d34912dac09
Author: Ben Pfaff <blp at nicira.com>
dpif-linux: Fix theoretical memory leak on error path.
If a notification is bigger than 4 kB (I doubt it one would be), then the
lack of ofpbuf_uninit() would cause a memory leak.

Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/dpif-linux.c   |   18 ++++++++++--------
 lib/netdev-dummy.c |   14 +++++++-------
 lib/netdev-linux.c |   19 ++++++++++++-------
 lib/netdev.c       |    6 ++----
 4 files changed, 31 insertions(+), 26 deletions(-)

Open vSwitch

More information about the git mailing list