[ovs-git] Open vSwitch: odp-util: Always export the priority and skb_mark netlink attributes. (branch-1.11)

dev at openvswitch.org dev at openvswitch.org
Mon Aug 5 20:48:37 UTC 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.11 has been updated
       via  830255c9a3f7e3dd41b92105e91e7eb05a612c5a (commit)
      from  5a9157f606bfcbe2f8079ea91af3e09756da3b09 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 830255c9a3f7e3dd41b92105e91e7eb05a612c5a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=830255c9a3f7e3dd41b92105e91e7eb05a612c5a
Author: Andy Zhou <azhou at nicira.com>
odp-util: Always export the priority and skb_mark netlink attributes.
The current Netlink protocol allows a default value of zero if either mark
or priority is not specified (this is part of the ABI).  Until now, when
userspace serializes either the value or mask, it looked at the value and
omitted the netlink attribute if it is zero.  This is a bug because an
exact match on zero turns into a wildcard of the field.

These two fields (plus input port and EtherType) are special because they
can be omitted whereas most other values are required to be fully
specified.  These protocol variations tend to cause bugs (as above) when we
evolve the protocol because an exception that makes sense in one context
might not be logical in another.  Since the default value for mark and
priority are merely shorthands, we can push the protocol in a more
consistent direction by ignoring the shortcut and always serializing the
values.  This is what this commits does.

Signed-off-by: Andy Zhou <azhou at nicira.com>
[blp at nicira.com added Jesse's text to the commit message]
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 lib/odp-util.c        |    8 ++------
 tests/odp.at          |   33 +++++++++++++++++++--------------
 tests/ofproto-dpif.at |   18 +++++++++---------
 3 files changed, 30 insertions(+), 29 deletions(-)

Open vSwitch

More information about the git mailing list