[ovs-git] Open vSwitch: netdev: Make netdev_from_name() take a reference to its returned netdev. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Aug 8 07:05:08 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  991e5fae57752bc76a63027c5a8ac4a470e0f54f (commit)
       via  2f980d741737fd3296d8063d800753a2d77bd730 (commit)
       via  89608a13e3bee2bf92456033c1573014a7d939c3 (commit)
       via  35bacb7fe3e00ce43518ff0a28bb8340e37be373 (commit)
       via  c22762302c290fceccb14c2e33097fd6b5f11f57 (commit)
       via  887ed8b26fdfe94217e07d2a2d5fc745dd7d24b4 (commit)
       via  1755ec40046c188132213920f6795e878d98035b (commit)
       via  d0d08f8aa5272943f2388a7cc18eeeda0288627d (commit)
       via  93ecae1914e3f8879e6aa7224439edd07daeffd0 (commit)
       via  9366380ae854726888c228830301cf9a54fbee4c (commit)
       via  9da7ae1298d570a5170515cfcf3356270541d8ad (commit)
       via  2b906eca2a06b2d351118041bc9a7b8d118eb626 (commit)
       via  a5440992d69e488e58424dfea2a0c45e5dc1c7e4 (commit)
       via  6de8e4b2e8ef5aaf24df623896f563cc08d98a53 (commit)
       via  23e29ebb84d59313d4bd2d51fc7efb3f8917cff0 (commit)
      from  2fbf137dbb3a93c25691b146f308a4d158f7c8da (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 991e5fae57752bc76a63027c5a8ac4a470e0f54f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=991e5fae57752bc76a63027c5a8ac4a470e0f54f
Author: Ben Pfaff <blp at nicira.com>
		
netdev: Make netdev_from_name() take a reference to its returned netdev.
		
This API change is necessary for thread safety, to be added in an upcoming
commit.  Otherwise, the client would not be able to safely use the returned
netdev because it could already have been destroyed.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 2f980d741737fd3296d8063d800753a2d77bd730
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2f980d741737fd3296d8063d800753a2d77bd730
Author: Ben Pfaff <blp at nicira.com>
		
netdev: Make netdev_get_devices() take a reference to each netdev.
		
This API change is necessary for thread safety, to be added in an upcoming
commit.  Otherwise, the client would not be able to actually use any of
the returned netdevs because they could already have been destroyed.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 89608a13e3bee2bf92456033c1573014a7d939c3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=89608a13e3bee2bf92456033c1573014a7d939c3
Author: Ben Pfaff <blp at nicira.com>
		
netdev-provider: Remove unused function netdev_assert_class().
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 35bacb7fe3e00ce43518ff0a28bb8340e37be373
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=35bacb7fe3e00ce43518ff0a28bb8340e37be373
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Use xmemdup0() to simplify netdev_bsd_get_next_hop().
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
CC: Ed Maste <emaste at freebsd.org>
CC: YAMAMOTO Takashi <yamt at mwd.biglobe.ne.jp>


commit c22762302c290fceccb14c2e33097fd6b5f11f57
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c22762302c290fceccb14c2e33097fd6b5f11f57
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Move variable declaration inward in netdev_linux_cache_cb().
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 887ed8b26fdfe94217e07d2a2d5fc745dd7d24b4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=887ed8b26fdfe94217e07d2a2d5fc745dd7d24b4
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Remove useless member 'peer', which was always zero.
		
Always, correct a comment on netdev_linux_get_features().

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 1755ec40046c188132213920f6795e878d98035b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1755ec40046c188132213920f6795e878d98035b
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Remove unused struct netdev_linux member.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit d0d08f8aa5272943f2388a7cc18eeeda0288627d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d0d08f8aa5272943f2388a7cc18eeeda0288627d
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Remove pointless layers of indirection for tap devices.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 93ecae1914e3f8879e6aa7224439edd07daeffd0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=93ecae1914e3f8879e6aa7224439edd07daeffd0
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Remove unneeded struct forward declarations from header.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 9366380ae854726888c228830301cf9a54fbee4c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9366380ae854726888c228830301cf9a54fbee4c
Author: Ben Pfaff <blp at nicira.com>
		
netdev-vport: Use ovs_mutex rather than a raw pthread_mutex_t.
		
I'd forgotten even to use the xpthread variants here.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>


commit 9da7ae1298d570a5170515cfcf3356270541d8ad
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9da7ae1298d570a5170515cfcf3356270541d8ad
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Don't assume 'struct netdev' has offset 0.
		
The data items returned by netdev_get_devices() are "struct netdev *"s.
The code fixed up by this commit used them as "struct netdev_bsd *",
which happens to work because struct netdev happens to be at offset 0 in
each struct but it's better to do a proper cast in case someday
struct netdev gets moved to a nonzero offset.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 2b906eca2a06b2d351118041bc9a7b8d118eb626
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2b906eca2a06b2d351118041bc9a7b8d118eb626
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Correctly handle IPv4 netmasks.
		
netdev_bsd_get_in4() did not set anything in its 'netmask' output argument
if the IPv4 address was cached, leaving it indeterminate.  It would also
mark the cache as valid even if there was an error retrieving the netmask.
This fixes both problems.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at nicira.com>
CC: Ed Maste <emaste at freebsd.org>


commit a5440992d69e488e58424dfea2a0c45e5dc1c7e4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a5440992d69e488e58424dfea2a0c45e5dc1c7e4
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Fix fd leak on error path.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
CC: Ed Maste <emaste at freebsd.org>


commit 6de8e4b2e8ef5aaf24df623896f563cc08d98a53
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6de8e4b2e8ef5aaf24df623896f563cc08d98a53
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Fix typo in label name.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
CC: Ed Maste <emaste at freebsd.org>


commit 23e29ebb84d59313d4bd2d51fc7efb3f8917cff0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=23e29ebb84d59313d4bd2d51fc7efb3f8917cff0
Author: Ben Pfaff <blp at nicira.com>
		
netdev-bsd: Fix memory leak on error path.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
CC: Ed Maste <emaste at freebsd.org>


-----------------------------------------------------------------------

Summary of changes:
 lib/netdev-bsd.c      |   78 +++++++++++++++++++++++--------------------------
 lib/netdev-linux.c    |   65 +++++++++++++++--------------------------
 lib/netdev-linux.h    |    2 --
 lib/netdev-provider.h |    6 ----
 lib/netdev-vport.c    |    6 ++--
 lib/netdev.c          |   22 ++++++++++----
 6 files changed, 78 insertions(+), 101 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list