[ovs-git] Open vSwitch: ofproto-dpif: Fix bad pointer dereference when deleting a bridge. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Aug 16 01:01:28 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  24623c9175d3c1373cf70a0cb95d11b3c655a2e3 (commit)
       via  c09f755dff4a7c0f78d59d1388461be3ec7e6895 (commit)
      from  448a4b2fc74b9d3884f3702c4b8801eb0d443f10 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 24623c9175d3c1373cf70a0cb95d11b3c655a2e3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=24623c9175d3c1373cf70a0cb95d11b3c655a2e3
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix bad pointer dereference when deleting a bridge.
		
The 'pins' list contains packet-ins, not flow-mods.

Introduced by commit ada3a58d1f8 (ofproto-dpif: Make packet_ins thread
safe.).

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit c09f755dff4a7c0f78d59d1388461be3ec7e6895
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c09f755dff4a7c0f78d59d1388461be3ec7e6895
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Avoid extra O(N) work in common case on flow addition.
		
The OpenFlow OFPFF_CHECK_OVERLAP flag requires us to check whether the flow
being inserted overlaps with any existing flows.  That isn't efficiently
implemented and typically requires us to compare the new flow against most
or all of the existing flows.  We don't have to do that work if
OFPFF_CHECK_OVERLAP is not requested, but commit 0b4f207828c (classifier:
Make use of the classifier thread safe.) inadvertently made us do it
anyway.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |    4 ++--
 ofproto/ofproto.c      |   20 ++++++++++++--------
 2 files changed, 14 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list