[ovs-git] Open vSwitch: Reinterpret base for meter band types bitmap. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Aug 21 20:07:08 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6e055a6cf022188286f1e5e6f9d7431dab101b50 (commit)
      from  a54667e5d475ad7be71f2e25067c9190d785014f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6e055a6cf022188286f1e5e6f9d7431dab101b50
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6e055a6cf022188286f1e5e6f9d7431dab101b50
Author: Ben Pfaff <blp at nicira.com>
		
Reinterpret base for meter band types bitmap.
		
OpenFlow 1.3 says that the band_types member of struct ofp_meter_features
is a bitmap of OFPMBT_* values.  The OFPMBT_* values are 1-based, so
until now, to avoid wasting bit 0, OVS mapped an OFPMBT_* with value 1 to
bit 0, value 2 to bit 1, and so on.  However, according to
http://openvswitch.org/pipermail/dev/2013-July/029666.html,
other OpenFlow implementations directly translate value 1 to bit 1,
value 2 to bit 2, and so on.  This commit changes Open vSwitch to use this
more common interpretation.

A request for clarification of this issue in the OpenFlow standard has been
filed with the ONF Extensibility Working Group as issue EXT-345.

Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-print.c    |    8 ++------
 tests/ofp-print.at |    2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list