[ovs-git] Open vSwitch: ofproto-dpif-xlate: Refactor xlate_table_action() to avoid Clang warnings. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Aug 23 18:06:23 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  bb61b33de6d6b8488aabf76419371a13ddecde36 (commit)
       via  ff59f2d454eece2b7e04cfbaee59fbcc9ef58e32 (commit)
      from  dfbdea46729530cda086ff7d2f14474a37de1408 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bb61b33de6d6b8488aabf76419371a13ddecde36
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=bb61b33de6d6b8488aabf76419371a13ddecde36
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif-xlate: Refactor xlate_table_action() to avoid Clang warnings.
		
I get a bunch of thread-safety warnings with the latest Clang without this
patch, because Clang is smart enough to see locking and unlocking but not
smart enough to figure out the relationships.  This refactoring avoids the
warnings.

I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit ff59f2d454eece2b7e04cfbaee59fbcc9ef58e32
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ff59f2d454eece2b7e04cfbaee59fbcc9ef58e32
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix thread safety annotation on rule_dpif_lookup_in_table().
		
New Clang versions raise warnings about the incorrect old annotation.

I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif-xlate.c |   55 +++++++++++++++++++++++-------------------
 ofproto/ofproto-dpif.c       |    2 +-
 ofproto/ofproto-dpif.h       |    2 +-
 3 files changed, 32 insertions(+), 27 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list