[ovs-git] Open vSwitch: lacp: Make lacp negotiation test hard-code aggregation keys. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Dec 11 19:13:40 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  b369c2334ed047cf4a4f0eed29ce35abaa1edbaf (commit)
       via  4f6b99348189f728a734aaf3b551410ee8b07f0c (commit)
       via  202a4b176e939574b643651dceef22097ce23780 (commit)
       via  c799c30657373c68b243bdb2576bf1883bcfce4a (commit)
       via  1a6495b5223687dc0998cbf2ab59aad312980f9f (commit)
       via  390eadaa790e7442d1738933937150c49e96d3d4 (commit)
      from  13751fd88c4b7464f9453c03659201c10b3b87a0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b369c2334ed047cf4a4f0eed29ce35abaa1edbaf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b369c2334ed047cf4a4f0eed29ce35abaa1edbaf
Author: Ben Pfaff <blp at nicira.com>
		
lacp: Make lacp negotiation test hard-code aggregation keys.
		
The lacp implementation takes the aggregation key from the key or portid
of the first slave to be added to the lacp object.  When multiple slaves
are added initially to a lacp object (the most common case), which is the
"first" is arbitrary.  Until now, it seems that the "first" was actually
predictable enough for the tests to (unknowingly) rely on it, but an
upcoming commit will break that.  This commit fixes the test by forcing
a particular aggregation key for each lacp object.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 4f6b99348189f728a734aaf3b551410ee8b07f0c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4f6b99348189f728a734aaf3b551410ee8b07f0c
Author: Ben Pfaff <blp at nicira.com>
		
netdev: Log a warning when netdev_set_config() fails.
		
This allows its callers to avoid duplicating the code.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 202a4b176e939574b643651dceef22097ce23780
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=202a4b176e939574b643651dceef22097ce23780
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Fix alphabetical order in list of structs.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit c799c30657373c68b243bdb2576bf1883bcfce4a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c799c30657373c68b243bdb2576bf1883bcfce4a
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Make ofproto_enumerate_types() match its comment.
		
The comment says that it clears the passed-in sset, but it didn't.  The bug
didn't actually affect any of the existing callers, which all passed in an
empty sset.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 1a6495b5223687dc0998cbf2ab59aad312980f9f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1a6495b5223687dc0998cbf2ab59aad312980f9f
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-provider: Add comment on struct ofport.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 390eadaa790e7442d1738933937150c49e96d3d4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=390eadaa790e7442d1738933937150c49e96d3d4
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Improve comment.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netdev.c               |   12 +++++++++---
 ofproto/ofproto-dpif.c     |    2 +-
 ofproto/ofproto-provider.h |    2 ++
 ofproto/ofproto.c          |    1 +
 ofproto/ofproto.h          |    4 ++--
 tests/lacp.at              |   12 ++++++++----
 utilities/ovs-dpctl.c      |    2 --
 vswitchd/bridge.c          |    9 +--------
 8 files changed, 24 insertions(+), 20 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list