[ovs-git] Open vSwitch: tests/learn.at: Workaround a race (master)

dev at openvswitch.org dev at openvswitch.org
Fri Dec 20 16:01:23 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  15155807de9fd3e50f095494a694257e088555fe (commit)
       via  ac3c0be096b7aa8d3681dd1e298c37cc932e0da5 (commit)
       via  bf06c4fe3977f98cad16cecc891d50f826fcd5e3 (commit)
       via  f8b92eb858962b75ae17519489b4cd9f29a60203 (commit)
       via  26d4d4fb4f41dc018ccfb1842ceedeb7323b9fd5 (commit)
       via  226dfd837c760f9126b5a4312e88b0dee836b2ab (commit)
       via  dd310dd9356036c8f491c5e39a415afe9d308b5f (commit)
      from  bb754b255f527da21a4e0abbeaa5fef14b13f12b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 15155807de9fd3e50f095494a694257e088555fe
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15155807de9fd3e50f095494a694257e088555fe
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
tests/learn.at: Workaround a race
		
This test seems to assume that the switch completes
processing of the first packet before start processing
the second one.  I don't see any code ensuring that.
Workaround the problem by giving 1 second for the upcall.

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit ac3c0be096b7aa8d3681dd1e298c37cc932e0da5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ac3c0be096b7aa8d3681dd1e298c37cc932e0da5
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
timeval: Workaround for threaded test failures
		
BFD tests have the code like the following.

    # wait for a while to stablize everything.
    for i in `seq 0 9`; do ovs-appctl time/warp 500; done

They no longer work as intended because BFD code is run in a
separate monitor thread these days.  The loop merely "warp"
the time by 5000.  The monitor thread should have been woken
at least once, but it's far from "wait for a while to stablize
everything."

This commit mitigates the problem by sleeping a little in the
appctl handler.  This is not ideal but makes BFD tests success
on my environment.

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit bf06c4fe3977f98cad16cecc891d50f826fcd5e3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=bf06c4fe3977f98cad16cecc891d50f826fcd5e3
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
tests/ofproto-dpif.at: Workaround a race
		
This test seems to assume only the first packets in flows
counted as 'miss'.  I don't see any code ensuring that.
The test would fail if the upcall handler for the flow doesn't
run fast enough.  Workaround the problem by giving 1 second
for the miss upcall.

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit f8b92eb858962b75ae17519489b4cd9f29a60203
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f8b92eb858962b75ae17519489b4cd9f29a60203
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
ofproto-dpif-upcall: Reduce log level of "Spent unreasonably long" msg
		
This message can be caused by a time warp and make tests fail.

The message was introduced by commit e79a6c83.
("ofproto: Handle flow installation and eviction in upcall.")

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 26d4d4fb4f41dc018ccfb1842ceedeb7323b9fd5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=26d4d4fb4f41dc018ccfb1842ceedeb7323b9fd5
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
tests/ofproto.at: Avoid stdout/stderr ordering assumptions
		
Stop assuming the order of outputs from separate streams.
(stdout and stderr)

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 226dfd837c760f9126b5a4312e88b0dee836b2ab
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=226dfd837c760f9126b5a4312e88b0dee836b2ab
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
tests/ofproto-dpif.at: Portability improvement
		
The output of "wc -l" have leading spaces on some platforms.
(NetBSD, OSX, ...)

This fixes a test failure introduced by commit e79a6c83.
("ofproto: Handle flow installation and eviction in upcall.")

Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit dd310dd9356036c8f491c5e39a415afe9d308b5f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=dd310dd9356036c8f491c5e39a415afe9d308b5f
Author: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
		
tests/daemon-py.at: Skip if no python
		
Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/timeval.c                 |    1 +
 ofproto/ofproto-dpif-upcall.c |    2 +-
 tests/daemon-py.at            |    1 +
 tests/learn.at                |    3 +++
 tests/ofproto-dpif.at         |   14 ++++++++------
 tests/ofproto.at              |   13 ++++++++-----
 6 files changed, 22 insertions(+), 12 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list