[ovs-git] Open vSwitch: timeval: Avoid unnecessary integer overflow in time_alarm(). (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  75b0b752d8d70edcd08f18e1028d60537cdede85 (commit)
       via  3b9ed5937ac6fbfc885ed7c7b39a7708162bd8fb (commit)
       via  2bf1d3cc12de50fe05a2a61780ce2450be532084 (commit)
       via  8450059ee8c1564f5d3be2e5d9c303360d1226e4 (commit)
       via  e93af6a4790492e4eaf6ac4624fda6fcff26f209 (commit)
       via  0d7bb1b4f4982637b316e51a258e8efaabb3e431 (commit)
       via  a6b112a8b31fdf56a73cb539c0ab41672fc71712 (commit)
       via  316bd0f8229ec252ce714ca2ece8367a49d929c3 (commit)
      from  146356e958188ef0a9f32e66e674fee2cf669102 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75b0b752d8d70edcd08f18e1028d60537cdede85
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=75b0b752d8d70edcd08f18e1028d60537cdede85
Author: Ben Pfaff <blp at nicira.com>
		
timeval: Avoid unnecessary integer overflow in time_alarm().
		
Durations longer than 4294967 seconds would unnecessarily overflow in the
multiplication here.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 3b9ed5937ac6fbfc885ed7c7b39a7708162bd8fb
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3b9ed5937ac6fbfc885ed7c7b39a7708162bd8fb
Author: Ben Pfaff <blp at nicira.com>
		
worker: Use ovs_retval_to_string() where EOF is a possible return value.
		
Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 2bf1d3cc12de50fe05a2a61780ce2450be532084
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2bf1d3cc12de50fe05a2a61780ce2450be532084
Author: Ben Pfaff <blp at nicira.com>
		
unixctl: Use ovs_retval_to_string() where EOF is a possible value.
		
jsonrpc_transact_block() might return EOF so passing its return value to
strerror() isn't general enough.

It might be better to change jsonrpc_transact{_block}() to never return
EOF, since a closed connection seems like it is always an error in that
context.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 8450059ee8c1564f5d3be2e5d9c303360d1226e4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8450059ee8c1564f5d3be2e5d9c303360d1226e4
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Check return value of set_nonblocking().
		
It's unlikely to fail but checking it can't hurt.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit e93af6a4790492e4eaf6ac4624fda6fcff26f209
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e93af6a4790492e4eaf6ac4624fda6fcff26f209
Author: Ben Pfaff <blp at nicira.com>
		
process: Check return value of set_nonblocking().
		
It's unlikely to fail but checking it can't hurt.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 0d7bb1b4f4982637b316e51a258e8efaabb3e431
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0d7bb1b4f4982637b316e51a258e8efaabb3e431
Author: Ben Pfaff <blp at nicira.com>
		
bridge: Rename iface_create() variable to avoid hiding parameter.
		
This function has a parameter 'ofp_port' and a local variable 'ofp_port',
so rename the local variable to reduce confusion.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit a6b112a8b31fdf56a73cb539c0ab41672fc71712
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a6b112a8b31fdf56a73cb539c0ab41672fc71712
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Rename ofputil_port_from_string() variable to avoid hiding param.
		
This function has a parameter 's' and a local variable 's', so rename the
local variable to reduce confusion.

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 316bd0f8229ec252ce714ca2ece8367a49d929c3
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=316bd0f8229ec252ce714ca2ece8367a49d929c3
Author: Ben Pfaff <blp at nicira.com>
		
vlog: New function vlog_set_levels_from_string_assert().
		
Two of the users of vlog_set_levels_from_string() in the tests could have
silently failed, if their arguments were invalid.  This avoids that problem
(and a memory leak).

Found by Coverity.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netdev-linux.c |    6 +++++-
 lib/ofp-util.c     |   10 +++++-----
 lib/process.c      |   12 +++++++++---
 lib/timeval.c      |    4 ++--
 lib/unixctl.c      |    4 ++--
 lib/vlog.c         |   10 ++++++++++
 lib/vlog.h         |    5 +++--
 lib/worker.c       |    2 +-
 tests/test-odp.c   |    6 +++---
 vswitchd/bridge.c  |    4 ++--
 10 files changed, 42 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
Open vSwitch