[ovs-git] Open vSwitch: ovs-bugtool: Remove unused code and nonrequired commands. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Feb 14 22:33:16 UTC 2013

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  8d79e6a0202e65b1b64975f1023ccf6b34f89a71 (commit)
       via  f07902cdc092123d25f35321c8c74e446863d52e (commit)
       via  65e0f34ea85974e281cffd688869567c5a06cd26 (commit)
       via  ced171980cbe8c9eb430e920ff6854287831c335 (commit)
       via  659fd90c570487b9b7a2f37dddf30a7eced927d4 (commit)
       via  43516d93396b37e88391a49871b67311bcbb1fa5 (commit)
      from  7d82ab2e6e4223a78c242616a0d72f032d7867e7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8d79e6a0202e65b1b64975f1023ccf6b34f89a71
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8d79e6a0202e65b1b64975f1023ccf6b34f89a71
Author: Gurucharan Shetty <gshetty at nicira.com>
ovs-bugtool: Remove unused code and nonrequired commands.
There is some code that is unused and some commands whose
output we probably don't need to debug openvswitch issues.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

commit f07902cdc092123d25f35321c8c74e446863d52e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f07902cdc092123d25f35321c8c74e446863d52e
Author: Gurucharan Shetty <gshetty at nicira.com>
ovs-bugtool: Change the default output type.
In my tests, I see that creating a tar.gz takes a lot less
time than creating a tar.bz2. The difference in compressed
size of the debug bundle is not much different when either
of the above is used. So, use tar.gz as the default debug
bundle type.

Test results in my setup:
For an uncompressed debug bundle size of 250MB(95% of it is log files),
bz2 takes 50 seconds whereas gz takes 8 seconds. xz took 90 seconds.
gz, bz2 and xz compressed the debug bundle into 144M, 139M and 131M

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

commit 65e0f34ea85974e281cffd688869567c5a06cd26
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=65e0f34ea85974e281cffd688869567c5a06cd26
Author: Gurucharan Shetty <gshetty at nicira.com>
ovs-bugtool: Don't run a few ethtool commands on virtual devices.
There can be a few hundred virtual interfaces in a hypervisor.
Some of the ethtool commands that we currently run on these devices
probably does not provide any extra information. So remove them
for tap and vif interfaces.

Also bump up the size limitation for CAP_NETWORK_STATUS. The
current value is quite low and a 50 MB limit pre-compression
does not add much to the overall size.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

commit ced171980cbe8c9eb430e920ff6854287831c335
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ced171980cbe8c9eb430e920ff6854287831c335
Author: Gurucharan Shetty <gshetty at nicira.com>
ovs-bugtool: Ability to collect the number of rotated logs.
A big reason for a large debug bundle size is the size of log
files. By default we collect 20 rotated logs for each logfile.
Most of the times we collect the debug bundle as soon as we
hit a bug. In such cases, we know that we need only one day's
worth of logs.

This patch adds an option, '--log-days' to ovs-bugtool wherein
we can specify how many days worth of rotated logs do we need
as part of the debug bundle.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

commit 659fd90c570487b9b7a2f37dddf30a7eced927d4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=659fd90c570487b9b7a2f37dddf30a7eced927d4
Author: Gurucharan Shetty <gshetty at nicira.com>
ovs-bugtool: Provide a separate capability to openvswitch logs.
Currently we have a 50 MB size limitation for all logs. This looks
quite less because a single uncompressed log can be 50 MB which
will result in ovs-bugtool picking a single log.

While debugging issues related to openvswitch, it is important that
we have all logs related to openvswitch atleast. This patch provides
a new capability for openvswitch logs with no size limitation. This
should not be a problem since compression reduces the size of the logs
quite a bit.

Also increase the size limitation for the regular system logs to 200 MB.

A future commit adds an option '--log-days' to control the number of logs
that we collect.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

commit 43516d93396b37e88391a49871b67311bcbb1fa5
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=43516d93396b37e88391a49871b67311bcbb1fa5
Author: Gurucharan Shetty <gshetty at nicira.com>
rhel, xenserver: Make logrotate daily and compress old logs.
The default values can be different and usually comes from /etc/logrotate.conf.

For xenserver6.0.2, the values in /etc/logrotate.conf is daily and compress.
So this patch does not make any difference. But it does future proof against
any changes in xenserver in the future.

For rhel6.1, the values are weekly and un-compress.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>


Summary of changes:
 rhel/etc_logrotate.d_openvswitch      |    2 +
 utilities/bugtool/ovs-bugtool.8.in    |   11 ++-
 utilities/bugtool/ovs-bugtool.in      |  144 +++++++--------------------------
 xenserver/etc_logrotate.d_openvswitch |    2 +
 4 files changed, 42 insertions(+), 117 deletions(-)

Open vSwitch

More information about the git mailing list