[ovs-git] Open vSwitch: tests: Fix memory leaks in test-classifier program. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jan 10 16:35:03 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  f2f3f5cbde7c1b27f7eaeefd7165d8780fcc11d7 (commit)
       via  0c09d44e6937e0eac39fd8b014a9bf0bd2412be8 (commit)
      from  ee382d89186673e2308b6fca5e4904279600c25b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit f2f3f5cbde7c1b27f7eaeefd7165d8780fcc11d7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f2f3f5cbde7c1b27f7eaeefd7165d8780fcc11d7
Author: Ben Pfaff <blp at nicira.com>
		
tests: Fix memory leaks in test-classifier program.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 0c09d44e6937e0eac39fd8b014a9bf0bd2412be8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0c09d44e6937e0eac39fd8b014a9bf0bd2412be8
Author: Ben Pfaff <blp at nicira.com>
		
classifier: Fix theoretical leak in classifier_destroy().
		
The open-coded version of destroy_table() in classifier_destroy() didn't
free the table's minimatch.  Use destroy_table() to do it properly.

This is only a theoretical leak because all the existing callers actually
remove all the rules from their classifiers before they destroy them
(outside of the tests/ directory, which I didn't examine) and so they don't
ever have anything left to remove in classifier_destroy().

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/classifier.c        |    4 +---
 tests/test-classifier.c |   19 +++++++++++++++++--
 2 files changed, 18 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list