[ovs-git] Open vSwitch: alloc_ofp_port does not allocate the port number correctly (master)

dev at openvswitch.org dev at openvswitch.org
Fri Jan 11 23:07:30 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6033d9d9d7058b1fb83f8235a6eed0572285b97c (commit)
      from  8e70e196a26404ab9e2f881cb8c383ef5fc4af29 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6033d9d9d7058b1fb83f8235a6eed0572285b97c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6033d9d9d7058b1fb83f8235a6eed0572285b97c
Author: Krishna Kondaka <kkondaka at vmware.com>
		
alloc_ofp_port does not allocate the port number correctly
		
alloc_ofp_port() does not allocate the port number correctly if the port
number passed initially is already in use. The following if block

if (ofp_port >= ofproto->max_ports
            || bitmap_is_set(ofproto->ofp_port_ids, ofp_port)) {

is entered when either of the two conditions is true but the while block
after this is not entered if the second condition above is true and the
first condition is false.

This results in an existing port_number to be re-assigned!

Signed-off-by: Krishna Kondaka <kkondaka at vmware.com>
Signed-off-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 AUTHORS           |    1 +
 ofproto/ofproto.c |   30 +++++++++++-------------------
 2 files changed, 12 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list