[ovs-git] Open vSwitch: ofproto-dpif: Actually log errors in facet_check_consistency() (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jun 6 18:14:18 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  c0a71f4e62617a9dbdd19089e22ec29b594f3860 (commit)
      from  37cd552e93cef42145adc9b8b219710a0296f6f9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c0a71f4e62617a9dbdd19089e22ec29b594f3860
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c0a71f4e62617a9dbdd19089e22ec29b594f3860
Author: Simon Horman <horms at verge.net.au>
		
ofproto-dpif: Actually log errors in facet_check_consistency()
		
facet_check_consistency() goes to some effort to create informative
error messages, protected by a rate limit, but does not actually
log these messages.

This appears to be an unintended side effect of
4dff90977694784e67e9c08cc72dee28ebc343ae ("ofproto-dpif: Move
odp_actions from subfacet to facet.").  This patch restores the
logging behaviour present prior to the above commit.

This patch also reverses a changes made by the same commit to use
ds_put_cstr() instead of ds_put_char() in facet_check_consistency().

Cc: Justin Pettit <jpettit at nicira.com>
Cc: Ethan Jackson <ethan at nicira.com>
Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list