[ovs-git] Open vSwitch: datapath: Increase maximum allocation size of action list. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Mar 1 02:02:34 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  9ccb22ec5f0a9edcba39a1c60469582496a70f8c (commit)
       via  ba4004356c0dc634a924beb75e878327e1e066e2 (commit)
      from  ef5b15acd4e87a283dedb68dcd81dbd1d7c521c6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9ccb22ec5f0a9edcba39a1c60469582496a70f8c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9ccb22ec5f0a9edcba39a1c60469582496a70f8c
Author: Pravin B Shelar <pshelar at nicira.com>
		
datapath: Increase maximum allocation size of action list.
		
The switch to flow based tunneling increased the size of each output
action in the flow action list.  In extreme cases, this can result
in the action list exceeding the maximum buffer size.
This doubles the maximum buffer size to compensate for the increase
in action size.
Action list is recieved from netlink callback which is allocating
linear-skb, therefore allocating another multi-page buffer would
not increase probability of the allocation-failure a lot.

Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>

Bug #15203


commit ba4004356c0dc634a924beb75e878327e1e066e2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ba4004356c0dc634a924beb75e878327e1e066e2
Author: Pravin B Shelar <pshelar at nicira.com>
		
Revert "datapath: Increase maximum allocation size of action list."
		
This reverts commit 82b0d755094ec675ea1a49b4ae58bc1c5e8e51c2.

This patch introduced bug by calling vfree() from interrupt context.

Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |    8 ++++----
 datapath/flow.c     |   19 ++-----------------
 datapath/flow.h     |    5 +----
 3 files changed, 7 insertions(+), 25 deletions(-)


hooks/post-receive
-- 
Open vSwitch


More information about the git mailing list