[ovs-git] Open vSwitch: datapath: Increase maximum allocation size of action list. (branch-1.10)

dev at openvswitch.org dev at openvswitch.org
Fri Mar 1 03:41:34 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.10 has been updated
       via  a0ae49a4abffebc1124947a836eaa276db4cb38c (commit)
       via  22f695248dc0f03fc7fffc7bcabf83c3a2e06491 (commit)
      from  cf1bc453f694046dabfdfc290bbe3ef043f2071f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a0ae49a4abffebc1124947a836eaa276db4cb38c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a0ae49a4abffebc1124947a836eaa276db4cb38c
Author: Pravin B Shelar <pshelar at nicira.com>
		
datapath: Increase maximum allocation size of action list.
		
The switch to flow based tunneling increased the size of each output
action in the flow action list.  In extreme cases, this can result
in the action list exceeding the maximum buffer size.
This doubles the maximum buffer size to compensate for the increase
in action size.
Action list is recieved from netlink callback which is allocating
linear-skb, therefore allocating another multi-page buffer would
not increase probability of the allocation-failure a lot.

Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>

Bug #15203


commit 22f695248dc0f03fc7fffc7bcabf83c3a2e06491
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=22f695248dc0f03fc7fffc7bcabf83c3a2e06491
Author: Pravin B Shelar <pshelar at nicira.com>
		
Revert "datapath: Increase maximum allocation size of action list."
		
This reverts commit 649b1c68fdd39316e3bcea21ce5464da614a6691.
This patch introduced bug by calling vfree() from interrupt context.

Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c |    8 ++++----
 datapath/flow.c     |   19 ++-----------------
 datapath/flow.h     |    5 +----
 3 files changed, 7 insertions(+), 25 deletions(-)


hooks/post-receive
-- 
Open vSwitch


More information about the git mailing list