[ovs-git] Open vSwitch: ofproto-dpif: Fix up user specifying wrong bridge on "ofproto/trace". (master)

dev at openvswitch.org dev at openvswitch.org
Fri Mar 8 18:34:03 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  6d19911609f659f6e582e53b1c0d4ffca16c0b80 (commit)
      from  55599423a9ed7f42a8f48a55947bd4bc955e94e9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6d19911609f659f6e582e53b1c0d4ffca16c0b80
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=6d19911609f659f6e582e53b1c0d4ffca16c0b80
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif: Fix up user specifying wrong bridge on "ofproto/trace".
		
If there is more than one bridge, then it's easy to specify the wrong one
on an ofproto/trace command.  Previously, this would produce surprising
results.  With this commit, "ofproto/trace" should silently fix up the
problem.

It would be nice to not require the user to specify a bridge at all, but
it's theoretically possible to have more than one backer, in which case we
need some way to distinguish, and a bridge name is as good an identifier
as we have.  We could ask the user to specify the datapath_type, I guess,
but that's a less familiar name to most users and it would be a somewhat
gratuitous change in synatx for ofproto/trace.

Bug #15419.
Reported-by: Paul Ingram <paul at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list