[ovs-git] Open vSwitch: vconn: Mark class structures as const. (master)

dev at openvswitch.org dev at openvswitch.org
Fri May 3 20:32:40 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5b7126361fd96de4b2609c64b62cb1774a1c4388 (commit)
       via  a00d4bd03640dff91d3d73a063b6dde91fe52cd1 (commit)
       via  4b5f1d2cc30099ec7e055d0a4c455c2d905789fc (commit)
       via  112b76f6b96d1e796be17522ec765cccc99cbc07 (commit)
       via  edfbe9f7bc340fb696b6f3a20fa47a536610eb38 (commit)
       via  559eb2308b4d616590aba34bb8f4dd7f12ae4587 (commit)
       via  e37726e467cf5523161c1b932b979a8818c76b25 (commit)
       via  07fc4ed3410006950012aef8d78f017c5b833e98 (commit)
       via  d64e176c3521c5132c0d9afa5718d52b7465453a (commit)
      from  ffb1cfd1445008a23fdc3276a6f8ecbeaac74279 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5b7126361fd96de4b2609c64b62cb1774a1c4388
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5b7126361fd96de4b2609c64b62cb1774a1c4388
Author: Ben Pfaff <blp at nicira.com>
		
vconn: Mark class structures as const.
		
These data structures are never modified so it seems logical for them
to be const.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit a00d4bd03640dff91d3d73a063b6dde91fe52cd1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a00d4bd03640dff91d3d73a063b6dde91fe52cd1
Author: Ben Pfaff <blp at nicira.com>
		
ofp-util: Make names[] in ofputil_action_code_from_name() const-ier.
		
This changes allows the compiler to put 'names' in a read-only section.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 4b5f1d2cc30099ec7e055d0a4c455c2d905789fc
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4b5f1d2cc30099ec7e055d0a4c455c2d905789fc
Author: Ben Pfaff <blp at nicira.com>
		
vlog: Mark more static data const.
		
These data structures are never modified so this seems like a
logical change.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 112b76f6b96d1e796be17522ec765cccc99cbc07
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=112b76f6b96d1e796be17522ec765cccc99cbc07
Author: Ben Pfaff <blp at nicira.com>
		
stream-fd: Mark 'fd_pstream_class' const.
		
These data structures are never modified so this seems like a
logical change.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit edfbe9f7bc340fb696b6f3a20fa47a536610eb38
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=edfbe9f7bc340fb696b6f3a20fa47a536610eb38
Author: Ben Pfaff <blp at nicira.com>
		
netdev: Make 'smap' variable const in netdev_set_qos().
		
This makes this code more obviously thread-safe.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 559eb2308b4d616590aba34bb8f4dd7f12ae4587
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=559eb2308b4d616590aba34bb8f4dd7f12ae4587
Author: Ben Pfaff <blp at nicira.com>
		
netdev-linux: Mark more static data as "const".
		
This makes this code more obviously thread-safe.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit e37726e467cf5523161c1b932b979a8818c76b25
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e37726e467cf5523161c1b932b979a8818c76b25
Author: Ben Pfaff <blp at nicira.com>
		
hmap: Make HMAP_INITIALIZER a valid initializer for a const hmap.
		
Without this change, an initialization such as
    const struct hmap map = HMAP_INITIALIZER(&map);
yields a compiler warning "initialization discards qualifiers from pointer
target type".

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 07fc4ed3410006950012aef8d78f017c5b833e98
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=07fc4ed3410006950012aef8d78f017c5b833e98
Author: Ben Pfaff <blp at nicira.com>
		
Make most "struct option" instances "const".
		
Reducing non-const static data makes code more obviously thread-safe.
Although option parsing does not normally need to be thread-safe, I
don't know of a drawback to making its data const.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit d64e176c3521c5132c0d9afa5718d52b7465453a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d64e176c3521c5132c0d9afa5718d52b7465453a
Author: Ben Pfaff <blp at nicira.com>
		
dpif-linux: Make dummy_action const in dpif_linux_init_flow_put().
		
This makes this code more obviously thread-safe.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dpif-linux.c           |    6 ++++--
 lib/hmap.h                 |    3 ++-
 lib/netdev-linux.c         |   30 ++++++++++++++----------------
 lib/netdev.c               |    2 +-
 lib/ofp-util.c             |    4 ++--
 lib/stream-fd.c            |    4 ++--
 lib/vconn-provider.h       |   20 ++++++++++----------
 lib/vconn-stream.c         |   20 ++++++++++----------
 lib/vconn.c                |   30 +++++++++++++++---------------
 lib/vlog.c                 |    6 +++---
 ovsdb/ovsdb-client.c       |    4 ++--
 ovsdb/ovsdb-server.c       |    2 +-
 ovsdb/ovsdb-tool.c         |    2 +-
 tests/test-jsonrpc.c       |    4 ++--
 tests/test-netflow.c       |    2 +-
 tests/test-ovsdb.c         |    2 +-
 tests/test-sflow.c         |    2 +-
 tests/test-util.c          |    2 +-
 utilities/ovs-benchmark.c  |    2 +-
 utilities/ovs-controller.c |    2 +-
 utilities/ovs-dpctl.c      |    2 +-
 utilities/ovs-ofctl.c      |    2 +-
 vswitchd/ovs-vswitchd.c    |    2 +-
 23 files changed, 78 insertions(+), 77 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list