[ovs-git] Open vSwitch: Always check return value of strftime(). (master)

dev at openvswitch.org dev at openvswitch.org
Wed May 8 17:55:11 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  3e78870d0bfc3be3255a7ca71588692c6615f0c7 (commit)
      from  dd43a558597bbf99a62541bc77e85f86f63e2f12 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3e78870d0bfc3be3255a7ca71588692c6615f0c7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3e78870d0bfc3be3255a7ca71588692c6615f0c7
Author: Ben Pfaff <blp at nicira.com>
		
Always check return value of strftime().
		
strftime() returns 0 and leaves the contents of the output buffer
unspecified if the output buffer is not big enough.  Thus, one should
check strftime()'s return value.  Until now, OVS has had a few invocations
of strftime() that did not check the return value.  This commit fixes
those.  I believe that the buffers were always large enough in each case,
but it's better to be safe.

Reported-by: Andy Zhou <azhou at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dynamic-string.c  |   23 +++++++++++++++++------
 lib/dynamic-string.h  |   12 +++++++-----
 lib/table.c           |   18 +++++++-----------
 lib/vlog.c            |   11 ++++-------
 ovsdb/ovsdb-tool.c    |    8 +++-----
 utilities/ovs-ofctl.c |    8 ++------
 6 files changed, 40 insertions(+), 40 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list