[ovs-git] Open vSwitch: odp-util: Fix IPFIX breakage with old kernel modules. (master)

dev at openvswitch.org dev at openvswitch.org
Mon Nov 11 21:07:11 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  96ed775f194a8a2461003533009be18c6e42c542 (commit)
       via  9ddf12cc12520acd7d09a8dfca74379faf0acf09 (commit)
      from  d1ba66e9ff0d4328967395e2af928d36c8955ad3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 96ed775f194a8a2461003533009be18c6e42c542
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=96ed775f194a8a2461003533009be18c6e42c542
Author: Ben Pfaff <blp at nicira.com>
		
odp-util: Fix IPFIX breakage with old kernel modules.
		
Before commit e995e3df57ea (Allow OVS_USERSPACE_ATTR_USERDATA to be
variable length.) userdata attributes in userspace actions were expected
to be exactly 64 bits long.  The kernel only actually enforced that they
were at least 64 bits long (the previously referenced commit's log message
contains misinformation on this account).

Initially this was no problem, because all of the userdata that userspace
actually used was exactly 8 bytes long.  Commit 29089a540c (Implement IPFIX
export), however, exposed a problem by reducing the length of userdata for
IPFIX support to just 4 bytes.  This meant that IPFIX no longer worked on
older datapaths, because the userdata was no longer at least 8 bytes long.

This commit fixes the problem by padding out userdata attributes less than
8 bytes long to 8 bytes.

CC: Romain Lenglet <rlenglet at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Romain Lenglet <rlenglet at vmware.com>


commit 9ddf12cc12520acd7d09a8dfca74379faf0acf09
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9ddf12cc12520acd7d09a8dfca74379faf0acf09
Author: Ben Pfaff <blp at nicira.com>
		
netlink: New function nl_msg_put_unspec_zero().
		
This function already had a few potential users, which this commit
converts.  An upcoming commit adds more users.

Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netlink.c  |   12 ++++++++++++
 lib/netlink.h  |    1 +
 lib/odp-util.c |   28 +++++++++++++++++++---------
 3 files changed, 32 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list