[ovs-git] Open vSwitch: ofp-actions: Consider L4 actions after mpls_push as inconsistent (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  94baabf754dde243e4cf5b7d0bfd9ca8def114ab (commit)
       via  c2c28dfd68eeb4744edb1375eae6ccc74201e812 (commit)
       via  ed2232fc7720ca482d3be097706e70588a31cb1f (commit)
       via  1af1ed8500bf10a1bd4f00bea6daaaa3e72578f8 (commit)
       via  c49a5e330820f6212c36954578a5e9f88f10f020 (commit)
      from  9080a11199cc9d5ea71e0348efc3e843d728e045 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 94baabf754dde243e4cf5b7d0bfd9ca8def114ab
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=94baabf754dde243e4cf5b7d0bfd9ca8def114ab
Author: Simon Horman <horms at verge.net.au>
		
ofp-actions: Consider L4 actions after mpls_push as inconsistent
		
After an mpls_push action the resulting packet is MPLS and
the MPLS payload is opaque. Thus nothing can be assumed
about the packets network protocol and it is inconsistent
to apply L4 actions.

With regards to actions that affect the packet at other layers
of the protocol stack:

* L3: The consistency of L3 actions should already be handled correctly
  by virtue of the dl_type of the flow being temporarily altered
  during consistency checking by both push_mpls and pop_mpls actions.

* MPLS: The consistency checking of MPLS actions appear to already be
  handled correctly.

* VLAN: At this time Open vSwitch on mpls_push an MPLS LSE is always
  added after any VLAN tags that follow the ethernet header.
  That is the tag ordering defined prior to OpenFlow1.3. As such
  VLAN actions should sill be equally valid before and after mpls_push
  and mpls_pop actions.

* L2 actions are equally valid before and after mpls_push and mpls_pop actions.

Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c2c28dfd68eeb4744edb1375eae6ccc74201e812
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c2c28dfd68eeb4744edb1375eae6ccc74201e812
Author: Ben Pfaff <blp at nicira.com>
		
Switch from sscanf() to ovs_scan() throughout the tree.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit ed2232fc7720ca482d3be097706e70588a31cb1f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=ed2232fc7720ca482d3be097706e70588a31cb1f
Author: Ben Pfaff <blp at nicira.com>
		
util: New function ovs_scan().
		
This new function is essentially an implementation of sscanf() with
slightly different behavior (see the comment) that is more convenient for
Open vSwitch internal use.  Also, this implementation ought to work out of
the box on Windows, which has a defective sscanf() that lacks the 'hh'
modifier required to scan into a char variable.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 1af1ed8500bf10a1bd4f00bea6daaaa3e72578f8
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1af1ed8500bf10a1bd4f00bea6daaaa3e72578f8
Author: Ben Pfaff <blp at nicira.com>
		
bitmap: New macro BITMAP_N_LONGS for use in constant expressions.
		
An upcoming commit will declare a bitmap on the stack, rather than heap
allocating it, which means that it is not possible to use a function call
in the declaration.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c49a5e330820f6212c36954578a5e9f88f10f020
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c49a5e330820f6212c36954578a5e9f88f10f020
Author: Ben Pfaff <blp at nicira.com>
		
meta-flow: Fix typo in error message.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/bitmap.h              |    6 +-
 lib/bond.c                |    7 +-
 lib/compiler.h            |    2 +
 lib/meta-flow.c           |   24 +-
 lib/netdev-linux.c        |   65 +++---
 lib/odp-util.c            |  555 +++++++++++++++++++--------------------------
 lib/ofp-actions.c         |    9 +-
 lib/ofp-parse.c           |    3 +-
 lib/packets.c             |    3 +-
 lib/packets.h             |   11 +-
 lib/util.c                |  443 ++++++++++++++++++++++++++++++++++++
 lib/util.h                |    2 +
 lib/vlandev.c             |    3 +-
 ovsdb/ovsdb.c             |    4 +-
 tests/library.at          |    3 +-
 tests/ofp-actions.at      |   12 +
 tests/test-util.c         |  533 +++++++++++++++++++++++++++++++++++++++++++
 utilities/ovs-benchmark.c |    4 +-
 utilities/ovs-dpctl.c     |    3 +-
 vswitchd/bridge.c         |    4 +-
 vswitchd/system-stats.c   |    6 +-
 21 files changed, 1307 insertions(+), 395 deletions(-)


hooks/post-receive
-- 
Open vSwitch