[ovs-git] Open vSwitch: ofproto-dpif-xlate: Suppress oversize datapath actions. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Oct 4 15:49:13 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  542024c4c3d36b2d303efbe6c0da469c8e446476 (commit)
       via  98b07853dfd6046938c41937d60ce693437c1f25 (commit)
      from  0585f7a88c7773737095e0eb2cf0f1222c0fed2e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 542024c4c3d36b2d303efbe6c0da469c8e446476
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=542024c4c3d36b2d303efbe6c0da469c8e446476
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif-xlate: Suppress oversize datapath actions.
		
If we allow oversize datapath actions to make it out of translation, then
we will assert-fail later when we try to put those actions into a Netlink
attribute.

Bug #19277.
Reported-by: Paul ingram <paul at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


commit 98b07853dfd6046938c41937d60ce693437c1f25
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=98b07853dfd6046938c41937d60ce693437c1f25
Author: Ben Pfaff <blp at nicira.com>
		
ofproto-dpif-xlate: Limit memory and time that translation can consume.
		
The resubmit depth has been limited to MAX_RESUBMIT_RECURSION, currently
64, for a long time.  But the flow "actions=resubmit:1, resubmit:2,
output:1" generates about 2**MAX_RESUBMIT_RECURSION output actions,
exhausting memory.  This commit fixes the problem.

Such a flow also requires 2**MAX_RESUBMIT_RECURSION time for translation.
This commit fixes that problem too.

Bug #19277.
Reported-by: Paul Ingram <paul at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netlink.c                |   12 +++++++-
 lib/netlink.h                |    4 ++-
 ofproto/ofproto-dpif-xlate.c |   41 ++++++++++++++++++++++-----
 tests/ofproto-dpif.at        |   64 ++++++++++++++++++++++++++++++++++++++++++
 tests/ofproto-macros.at      |    4 +++
 5 files changed, 116 insertions(+), 9 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list