[ovs-git] Open vSwitch: rconn: Make thread-safe. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Oct 11 17:13:34 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  9f5e8906e98786f2254eff53e337531aa70f1a59 (commit)
       via  4cd1bc9d103e03de4bdf28e815b1c4a0841e8c34 (commit)
       via  3b0c6b569f7d5957919eb170ae95c402db37186c (commit)
       via  a3d1ff00de09c1ea64cab59135d6eb0d0de369b0 (commit)
      from  30fe866b46dd6b5658dfa7c2fb60b8f756ea6f95 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f5e8906e98786f2254eff53e337531aa70f1a59
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=9f5e8906e98786f2254eff53e337531aa70f1a59
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Make thread-safe.
		
This should make sending OFPT_FLOW_REMOVED and NXST_FLOW_MONITOR safe from
miss handler threads.

Bug #20271.
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 4cd1bc9d103e03de4bdf28e815b1c4a0841e8c34
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=4cd1bc9d103e03de4bdf28e815b1c4a0841e8c34
Author: Ben Pfaff <blp at nicira.com>
		
connmgr: Formalize 'ofproto_mutex' as protecting ofconn monitor data.
		
'ofproto_mutex' has effectively protected the monitor-related members of
struct ofconn since its introduction, but this was not written down or
systematically annotated.  This commit makes it more systematic and fixes
a few issues found using the annotations.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit 3b0c6b569f7d5957919eb170ae95c402db37186c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3b0c6b569f7d5957919eb170ae95c402db37186c
Author: Ben Pfaff <blp at nicira.com>
		
connmgr: Use 'ofproto_mutex' to protect ofconns from being destroyed.
		
Code in the ofproto-dpif miss handler threads can currently access
ofconns, sending flow_removed and flow monitor messages due to NXAST_LEARN
actions.  Nothing currently protects those threads from accessing ofconns
that are in the process of being destroyed.  This commit adds protection
'ofproto_mutex', which NXAST_LEARN already takes.

Later patches will address other races that remain.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


commit a3d1ff00de09c1ea64cab59135d6eb0d0de369b0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a3d1ff00de09c1ea64cab59135d6eb0d0de369b0
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Make rconn_packet_counter thread-safe.
		
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/rconn.c       |  347 ++++++++++++++++++++++++++++++++++++++++++++---------
 lib/rconn.h       |   20 ++-
 ofproto/connmgr.c |  103 +++++++++++++---
 ofproto/connmgr.h |   17 ++-
 ofproto/ofproto.c |    4 +-
 5 files changed, 408 insertions(+), 83 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list