[ovs-git] Open vSwitch: More accurate wildcarding and fragment handling. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Oct 17 22:08:23 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  94639963bf275a41e42277116205da0e9b457580 (commit)
      from  a5ae88ff8a276e86c842ac102145432662bf711a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 94639963bf275a41e42277116205da0e9b457580
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=94639963bf275a41e42277116205da0e9b457580
Author: Jarno Rajahalme <jrajahalme at nicira.com>
		
More accurate wildcarding and fragment handling.
		
This patch gets rid of the need for having explicit padding in struct
flow as new fields are being added.  flow_wildcards_init_exact(), which
used to set bits in both compiler generated and explicit padding, is
removed.  match_wc_init() is now used instead, which generates the mask
based on a given flow, setting bits only in fields which make sense.

Places where random bits were placed in struct flow have been changed to
only set random bits on fields that are significant in the given context.
This avoids setting padding bits.

- lib/flow:
  - Properly initialize struct flow also in places we used to zero out
    padding before.
  - Add flow_random_hash_fields() used for testing.
  - Remove flow_wildcards_init_exact() to avoid initializing
     masks where compiler generated padding has bits set.
- lib/match.c match_wc_init(): Wildcard transport layer fields for later
  fragments, remove match_init_exact(), which used
  flow_wildcards_init_exact().
- tests/test-flows.c: use match_wc_init() instead of match_init_exact()
- tests/flowgen.pl: generate more accurate packets and flows when
  fragmenting, mark unavailable fields as wildcarded.

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/flow.c             |   49 ++++++++++++++++++++++++++------
 lib/flow.h             |   29 +++++++++++--------
 lib/match.c            |   13 +++------
 lib/match.h            |    1 -
 ofproto/ofproto-dpif.c |    4 +--
 tests/flowgen.pl       |   73 ++++++++++++++++++++++++++----------------------
 tests/test-bundle.c    |    4 +--
 tests/test-flows.c     |    2 +-
 tests/test-multipath.c |    4 +--
 9 files changed, 107 insertions(+), 72 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list