[ovs-git] Open vSwitch: ofproto: Rename struct rule's evict lock and use it more widely. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Sep 4 22:56:44 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  884e1dc43275683c9a2bf23ce4e46d8fb43a3d41 (commit)
       via  448c2fa80c7ef9358179a0cdc68cf1feca782e6d (commit)
       via  70742c7f54e7f1477da81219b064f786656b4aba (commit)
      from  8911c674fc310ef8767364e80c0128357e3d49d7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 884e1dc43275683c9a2bf23ce4e46d8fb43a3d41
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=884e1dc43275683c9a2bf23ce4e46d8fb43a3d41
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto: Rename struct rule's evict lock and use it more widely.
		
There are a few fields in struct rule which are accessible by
functions in ofproto-dpif and therefore need to accessed in a thread
safe manner.  This patch achieves this by generalizing the rules evict
rwlock and requiring a writelock to be held to edit them.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 448c2fa80c7ef9358179a0cdc68cf1feca782e6d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=448c2fa80c7ef9358179a0cdc68cf1feca782e6d
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto-dpif: Don't manage eviction groups from threads.
		
Managing eviction groups from threads was going to be difficult to do
in a performant thread-safe manner, so this patch punts the problem to
the main thread.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 70742c7f54e7f1477da81219b064f786656b4aba
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=70742c7f54e7f1477da81219b064f786656b4aba
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto-dpif: Hide struct rule_dpif internally.
		
By hiding struct rule_dpif inside ofproto-dpif, it becomes very clear
which attributes are accessed by multiple threads and need to be
protected by locks.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif-upcall.c |    6 +--
 ofproto/ofproto-dpif-xlate.c  |   27 ++++++------
 ofproto/ofproto-dpif-xlate.h  |    2 +
 ofproto/ofproto-dpif.c        |   98 ++++++++++++++++++++++++++++++++---------
 ofproto/ofproto-dpif.h        |   58 ++++++++++--------------
 ofproto/ofproto-provider.h    |   24 +++++-----
 ofproto/ofproto.c             |   90 +++++++++++++++++++++++--------------
 7 files changed, 192 insertions(+), 113 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list