[ovs-git] Open vSwitch: ovs-ofctl: Handle any number of buckets in group statistics (master)

dev at openvswitch.org dev at openvswitch.org
Thu Sep 5 20:02:33 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  646b2a9c80fc14f6b7efc8a978bd58c25ffdd49b (commit)
       via  56750e2e32e23025a0882e75f02d93ad556b77fa (commit)
      from  86189a8c0bfb60d57169178630e3898023305d55 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 646b2a9c80fc14f6b7efc8a978bd58c25ffdd49b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=646b2a9c80fc14f6b7efc8a978bd58c25ffdd49b
Author: Simon Horman <horms at verge.net.au>
		
ovs-ofctl: Handle any number of buckets in group statistics
		
struct ofputil_group_stats has an arbitrary limit
of 16 buckets for which it can record statistics.
However the code does not appear to enforce this
limit and it seems to me that the code could overflow.

This patch aims to remove the arbitrary limit by
changing the 'bucket_stats' field of struct ofputil_group_stats
from a fixed length array to a pointer whose storage is allocated and freed
as necessary.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 56750e2e32e23025a0882e75f02d93ad556b77fa
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=56750e2e32e23025a0882e75f02d93ad556b77fa
Author: Simon Horman <horms at verge.net.au>
		
Use enum ofp11_group_type in struct ofgroup
		
Use enum ofp11_group_type for the 'type' field of struct ofgroup
as the enum exactly covers all the valid values of the field.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/ofp-print.c            |    2 ++
 lib/ofp-util.c             |    5 ++++-
 lib/ofp-util.h             |    2 +-
 ofproto/ofproto-provider.h |    2 +-
 ofproto/ofproto.c          |    4 ++++
 5 files changed, 12 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list