[ovs-git] Open vSwitch: ofproto-dpif: Don't hold mac rwlock while calling send_packet(). (branch-2.0)

dev at openvswitch.org dev at openvswitch.org
Tue Sep 10 21:17:09 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-2.0 has been updated
       via  5542f936e769c02f72751cd1ac68ddc6de6feab1 (commit)
      from  a036776fc19cf321d990913fec2c1a1deef89600 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5542f936e769c02f72751cd1ac68ddc6de6feab1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5542f936e769c02f72751cd1ac68ddc6de6feab1
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto-dpif: Don't hold mac rwlock while calling send_packet().
		
Holding the mac learning rwlock while calling send_packet() which
calls xlate_actions() is dangerous because somewhere deep in the chain
the same lock might be acquired causing a deadlock.  Though we haven't
run into this problem in testing, it seems prudent to refactor it.

Reported-by: Ben Pfaff <blp at nicira.com>
Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif.c |   32 ++++++++++++++++++--------------
 1 file changed, 18 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list