[ovs-git] Open vSwitch: vlog: Fix formatting of milliseconds in Python log messages. (branch-2.0)

dev at openvswitch.org dev at openvswitch.org
Tue Sep 17 20:59:59 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-2.0 has been updated
       via  75ab5755897d3deda272fbc57ba4cf924e05d8ff (commit)
       via  340a92017eba6661e17698d0594d76b087d38b06 (commit)
       via  75dbe9e934e625d8adaab8222457240331a60546 (commit)
       via  45739ed1153f99471ca4c68b1a9576dcfdb6e497 (commit)
      from  68542154b46e18a96d871e421dcbfb630c7bf0b0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 75ab5755897d3deda272fbc57ba4cf924e05d8ff
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=75ab5755897d3deda272fbc57ba4cf924e05d8ff
Author: Ben Pfaff <blp at nicira.com>
		
vlog: Fix formatting of milliseconds in Python log messages.
		
Commit 2b31d8e713de7 (vlog: Report timestamps in millisecond resolution in
log messages.) introduced milliseconds to log messages by default, but the
Python version did not ensure that milliseconds were always formatted with
3 digits, so 3.001 was formatted as "3.1" and 3.012 as "3.12", and so on.
This commit fixes the problem.

CC: Paul Ingram <paul at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 340a92017eba6661e17698d0594d76b087d38b06
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=340a92017eba6661e17698d0594d76b087d38b06
Author: Paul Ingram <pingram at nicira.com>
		
ovsdb: write commit timestamps to millisecond resolution.
		
This is expected to make system debugging easier.

This raises two compatibility issues:
1. When a new ovsdb-tool reads an old database, it will multiply by 1000 any
  timestamp it reads which is less than 1<<31. Since this date corresponds to
  Jan 16 1970 this is unlikely to cause a problem.
2. When an old ovsdb-tool reads a new database, it will interpret the
  millisecond timestamps as seconds and report dates in the far future; the
  time of this commit is reported as the year 45672 (each second since the
  epoch is interpreted as 16 minutes).

Signed-off-by: Paul Ingram <pingram at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 75dbe9e934e625d8adaab8222457240331a60546
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=75dbe9e934e625d8adaab8222457240331a60546
Author: Paul Ingram <pingram at nicira.com>
		
ovsdb: Use DB load time, not on-disk commit times, for compaction.
		
The ovsdb-server compaction timing logic is written assuming monotonic
time at milliscond resolution but it calculated the next compaction time
based on the oldest commit in the database. This was a problem because
commit timestamps are written in wall-clock time to second resolution.

This commit calculates the next compaction time based on the time when
the database was first loaded or the last compaction was done, both in
monotonic time at millisecond resolution.

Signed-off-by: Paul Ingram <pingram at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 45739ed1153f99471ca4c68b1a9576dcfdb6e497
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=45739ed1153f99471ca4c68b1a9576dcfdb6e497
Author: Paul Ingram <pingram at nicira.com>
		
vlog: Report timestamps in millisecond resolution in log messages.
		
To make debugging easier.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Signed-off-by: Paul Ingram <pingram at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 NEWS                      |    3 +++
 lib/dynamic-string.c      |   21 ++++++++++++---------
 lib/dynamic-string.h      |    7 +++----
 lib/table.c               |    2 +-
 lib/timeval.c             |   46 +++++++++++++++++++++++++++++++++++++++++++++
 lib/timeval.h             |   10 ++++++++++
 lib/vlog.c                |   16 ++++++++--------
 lib/vlog.h                |    2 +-
 ovsdb/file.c              |   45 +++++++++++++-------------------------------
 ovsdb/ovsdb-tool.c        |   11 +++++++++--
 python/ovs/vlog.py        |    5 +++--
 tests/vlog.at             |    2 +-
 utilities/ovs-appctl.8.in |   11 +++++++++--
 utilities/ovs-ofctl.c     |    3 ++-
 14 files changed, 121 insertions(+), 63 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list