[ovs-git] Open vSwitch: ofproto: Allow ofproto_delete_flow() to delete hidden rules. (branch-2.0)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-2.0 has been updated
       via  a7f2b5b122822a7c8d4b84620d9466a927a0ac3b (commit)
      from  e59f4d1b6840c0b77e48e0c50739b979d14857c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a7f2b5b122822a7c8d4b84620d9466a927a0ac3b
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a7f2b5b122822a7c8d4b84620d9466a927a0ac3b
Author: Ben Pfaff <blp at nicira.com>
		
ofproto: Allow ofproto_delete_flow() to delete hidden rules.
		
Commit 97f63e57a8 (ofproto: Remove soon-to-be-invalid optimizations.)
changed ofproto_delete_flow() to use the general-purpose flow_mod
implementation.  However, the general-purpose flow_mod never matches hidden
flows, which are exactly the flows that ofproto_delete_flow()'s callers
want to delete.

This commit fixes the problem by allowing flow_mods that specify a priority
that can only be for a hidden flow to delete a hidden flow.  (This doesn't
allow OpenFlow clients to meddle with hidden flows because OpenFlow uses
only a 16-bit field to specify priority.)

I verified that, without this commit, if I change from one controller to
another with "ovs-vsctl set-controller", then the in-band rules for the
old controller remain.  With this commit, the old rules are removed.

Reported-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
Bug #19821.
Reported-by: Luca Giraudo <lgiraudo at vmware.com>
Bug #19888.
Reported-by: Ying Chen <yingchen at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Open vSwitch