[ovs-git] Open vSwitch: hmap: Make bad hash functions easier to find. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Sep 24 21:46:57 UTC 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  0c5e05bf515ceb5e3e4f7f01834054bb34519752 (commit)
      from  bab3c0b820111eaf50878863f82e479fea4fa8a3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0c5e05bf515ceb5e3e4f7f01834054bb34519752
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0c5e05bf515ceb5e3e4f7f01834054bb34519752
Author: Ben Pfaff <blp at nicira.com>
		
hmap: Make bad hash functions easier to find.
		
The hmap code has for a long time incremented a counter when a hash bucket
grew to have many entries.  This can let a developer know that some hash
function is performing poorly, but doesn't give any hint as to which one.
This commit improves the situation by adding rate-limited debug logging
that points out a particular line of code as the source of the poor hash
behavior.  It should make issues easier to track down.

Bug #19926.
Signed-off-by: Ben Pfaff <blp at nicira.com>
Lauded-by: Keith Amidon <keith at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/hmap.c |   38 ++++++++++++++++++++++++++++----------
 lib/hmap.h |   31 +++++++++++++++++++++++--------
 2 files changed, 51 insertions(+), 18 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list