[ovs-git] Open vSwitch: ofp-print: Fix misaligned data access in ofp_print_error_msg(). (branch-2.1)

dev at openvswitch.org dev at openvswitch.org
Sat Apr 5 18:23:38 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-2.1 has been updated
       via  aa03508aa7d654b13f490d15973308270c24762c (commit)
       via  21db3de7f1e1c0972efe3e735970630f39ade608 (commit)
       via  a205dff624fa2c14dfd13fdf493299f4bff998e2 (commit)
      from  fb2cc2df6ca44efede09ee04d5dc423dbfc4ce5d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit aa03508aa7d654b13f490d15973308270c24762c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=aa03508aa7d654b13f490d15973308270c24762c
Author: Ben Pfaff <blp at nicira.com>
		
ofp-print: Fix misaligned data access in ofp_print_error_msg().
		
The body of an OpenFlow error message often contains an inner OpenFlow
message, and when it does, the inner message starts at an odd multiple of 4
bytes from the beginning of the outer message.  That means that, on RISC
systems, accessing the inner message directly causes a bus error.  This
commit fixes the problem in a way that should make it difficult to recur.

This fixes the failure of tests 643, 645, and 651 on sparc seen here:
https://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=sparc&ver=2.1.0%2Bgit20140325-1&stamp=1396438624

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 21db3de7f1e1c0972efe3e735970630f39ade608
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=21db3de7f1e1c0972efe3e735970630f39ade608
Author: Ben Pfaff <blp at nicira.com>
		
packets: Fix misaligned data accesses for MPLS and SCTP fields.
		
The other 32-bit data fields in protocol headers were already using
ovs_16aligned_be32, but MPLS and SCTP had been overlooked.  This fixes
the failure of test 681 seen here:
https://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=sparc&ver=2.1.0%2Bgit20140325-1&stamp=1396438624

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit a205dff624fa2c14dfd13fdf493299f4bff998e2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a205dff624fa2c14dfd13fdf493299f4bff998e2
Author: Ben Pfaff <blp at nicira.com>
		
dpif-netdev: Unwildcard entire odp_port in dpif_netdev_mask_from_nlattrs().
		
One case in the dpif_netdev_mask_from_nlattrs() function accidentally
wildcarded only a 16-bit subset of the mask's odp_port.  On little-endian
machines this subset was the lower bits, which happened to work out OK,
but on big-endian machines this subset was the upper bits, which doesn't
work and causes a test failure.  (The problem was actually visible in the
test expected results on little-endian machines, but we had not noticed.)

This commit unwildcards the whole field, fixing the problem, and updates
the test expected results to match.

This fixes the failure of test 732 seen here:
https://buildd.debian.org/status/fetch.php?pkg=openvswitch&arch=sparc&ver=2.1.0%2Bgit20140325-1&stamp=1396438624

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dpif-netdev.c     |   10 ++++++++--
 lib/flow.c            |    7 ++++---
 lib/ofp-errors.c      |   11 +++++++----
 lib/ofp-print.c       |    5 +++--
 lib/packets.c         |   14 +++++++-------
 lib/packets.h         |    6 +++---
 tests/ofproto-dpif.at |    4 ++--
 7 files changed, 34 insertions(+), 23 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list