[ovs-git] Open vSwitch: tests/ofproto-dpif: Use vlog to test dpif behaviour. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Apr 10 00:02:54 UTC 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  c2a77f33adec720dd0551361c44359710ff15a03 (commit)
      from  4479846e52373d491f11b2bddaa5adaf54ca325d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c2a77f33adec720dd0551361c44359710ff15a03
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c2a77f33adec720dd0551361c44359710ff15a03
Author: Joe Stringer <joestringer at nicira.com>
tests/ofproto-dpif: Use vlog to test dpif behaviour.
Previously we made heavy use of the 'ovs-appctl dpif/dump-flows' command
to verify that flows were being installed into the datapath correctly.
However this is sensitive to timing, particularly when the behaviour of
revalidator threads is modified. A common race condition involves flows
being revalidated and deleted before the test script gets a chance to
connect to ovs-vswitchd and dump the datapath flows.

This patch reworks the tests to make use of the vlog facility for dpif,
checking for flow installation and flow dump messages. Most tests are
converted to check for flow installation, which should reduce these race
conditions significantly. For tests that require packet counts, these
will continue to check for flow_dump messages. Race conditions for these
should be reduced but not eliminated.

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Summary of changes:
 tests/ofproto-dpif.at |  229 +++++++++++++++++++++++++++++--------------------
 1 file changed, 137 insertions(+), 92 deletions(-)

Open vSwitch

More information about the git mailing list