[ovs-git] Open vSwitch: ofproto: Don't destroy mutex before its use. (master)

dev at openvswitch.org dev at openvswitch.org
Fri Apr 25 15:03:48 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5c09b672114fab2357c8ce71d608d486eb5ae1ae (commit)
       via  a4fdb0f3bdbfff1924afefd19239260ed429c193 (commit)
      from  a7ae938074d1c5e25e484eb7b6aca3f101adea38 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5c09b672114fab2357c8ce71d608d486eb5ae1ae
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5c09b672114fab2357c8ce71d608d486eb5ae1ae
Author: Gurucharan Shetty <gshetty at nicira.com>
		
ofproto: Don't destroy mutex before its use.
		
Currently, we are calling guarded_list_destroy()
to destroy a mutex and then go ahead and use it through
delete_group
 ->delete_group__
   ->handle_flow_mod__
    ->run_rule_executes
     ->guarded_list_pop_all

The group related unit tests cause ovs-vswitchd to crash
because of this (on windows).

Calling guarded_list_destroy() after delete_group() solves the
problem.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit a4fdb0f3bdbfff1924afefd19239260ed429c193
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a4fdb0f3bdbfff1924afefd19239260ed429c193
Author: Gurucharan Shetty <gshetty at nicira.com>
		
netdev: Initialize netdev_class_mutex.
		
This code path currently does not initialize
netdev_class_mutex.
dummy_enable
 ->netdev_dummy_register
   ->netdev_register_provider
     ->ovs_mutex_lock(&netdev_class_mutex)

ovsdb-server on windows crashes without it.

This commit adds a new initialization function.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/netdev.c      |   15 ++++++++++++++-
 ofproto/ofproto.c |    4 ++--
 2 files changed, 16 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list