[ovs-git] Open vSwitch: tests: Fix up "ofproto-dpif - ofproto-dpif-monitor 1". (master)

dev at openvswitch.org dev at openvswitch.org
Mon Apr 28 23:03:04 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  738cd849aff11047070ee1fb7855e4b04bd6837d (commit)
       via  05bf6d3c62e1d19e192d264682e8239196a56ee9 (commit)
       via  2a3fb0aa3c0eef580c11572089bacc65cfd4290a (commit)
       via  c5cf10598f8c9f4428291e9df3ecd72a05fb1ccf (commit)
       via  a3aabcd26f8f35d4e36cb6d98669c4e20e5e4c0c (commit)
       via  214694add2d8f6b936a1b664fd546e4f1c4967e2 (commit)
       via  8ba0a5227f6e6b50838c157bd303c2d5bf6f4e59 (commit)
       via  595ef8b10ad81c6033df53dfbfdb8c1b01f6de87 (commit)
       via  3308c696220bbfff36bf29b3e1b168449d57b3d7 (commit)
       via  1edc458d61d9846b743310d9dd37ad181b013e5f (commit)
      from  a5ed8fe32cb3c996837c61af2e358fa34dc9936f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 738cd849aff11047070ee1fb7855e4b04bd6837d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=738cd849aff11047070ee1fb7855e4b04bd6837d
Author: Ben Pfaff <blp at nicira.com>
		
tests: Fix up "ofproto-dpif - ofproto-dpif-monitor 1".
		
Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
thread.) fixed a race condition in a test.  Commit 8ba0a5227f6 (ovs-thread:
Make caller provide thread name when creating a thread.) slightly changed
the output that the test checked, breaking the test.  However, I was used
to the test occasionally failing due to the race (not realizing that the
race had been fixed) so I applied the commit anyway.

This commit fixes the broken test.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


commit 05bf6d3c62e1d19e192d264682e8239196a56ee9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=05bf6d3c62e1d19e192d264682e8239196a56ee9
Author: Ben Pfaff <blp at nicira.com>
		
ovs-thread: Add checking for mutex and rwlock initialization.
		
With glibc, a mutex or rwlock filled with all-zero-bytes is properly
initialized for use, but this is not true for any other libc that OVS
supports.  However, OVS gets a lot more testing with glibc than any other
libc.  This means that developers keep introducing bugs that do not
manifest on the main development platform.

This commit should help avoid the problem, by reusing the existing 'where'
members to indicate whether a mutex or rwlock has been initialized.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit 2a3fb0aa3c0eef580c11572089bacc65cfd4290a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2a3fb0aa3c0eef580c11572089bacc65cfd4290a
Author: Ben Pfaff <blp at nicira.com>
		
lacp: Don't lock potentially uninitialized mutex in lacp_status().
		
If the 'lacp' parameter is nonnull, then we know that the file scope mutex
has been initialized, since that's done as a side effect of creating a
lacp object, but otherwise there's no guarantee.

Signed-off-by: Ben Pfaff <blp at nicira.com>


commit c5cf10598f8c9f4428291e9df3ecd72a05fb1ccf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=c5cf10598f8c9f4428291e9df3ecd72a05fb1ccf
Author: Justin Pettit <jpettit at nicira.com>
		
Prepare for post-2.2.0 (2.2.90).
		
Signed-off-by: Justin Pettit <jpettit at nicira.com>


commit a3aabcd26f8f35d4e36cb6d98669c4e20e5e4c0c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a3aabcd26f8f35d4e36cb6d98669c4e20e5e4c0c
Author: Justin Pettit <jpettit at nicira.com>
		
Prepare for 2.2.0.
		
Signed-off-by: Justin Pettit <jpettit at nicira.com>


commit 214694add2d8f6b936a1b664fd546e4f1c4967e2
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=214694add2d8f6b936a1b664fd546e4f1c4967e2
Author: Ben Pfaff <blp at nicira.com>
		
ovs-rcu: Log a helpful warning when ovsrcu_synchronize() stalls.
		
This made it easier for me to find a thread that was causing stalls.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alex Wang <alexw at nicira.com>


commit 8ba0a5227f6e6b50838c157bd303c2d5bf6f4e59
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8ba0a5227f6e6b50838c157bd303c2d5bf6f4e59
Author: Ben Pfaff <blp at nicira.com>
		
ovs-thread: Make caller provide thread name when creating a thread.
		
Thread names are occasionally very useful for debugging, but from time to
time we've forgotten to set one.  This commit adds the new thread's name
as a parameter to the function to start a thread, to make that mistake
impossible.  This also simplifies code, since two function calls become
only one.

This makes a few other changes to the thread creation function:

    * Since it is no longer a direct wrapper around a pthread function,
      rename it to avoid giving that impression.

    * Remove 'pthread_attr_t *' param that every caller supplied as NULL.

    * Change 'pthread *' parameter into a return value, for convenience.

The system-stats code hadn't set a thread name, so this fixes that issue.

This patch is a prerequisite for making RCU report the name of a thread
that is blocking RCU synchronization, because the easiest way to do that is
for ovsrcu_quiesce_end() to record the current thread's name.
ovsrcu_quiesce_end() is called before the thread function is called, so it
won't get a name set within the thread function itself.  Setting the thread
name earlier, as in this patch, avoids the problem.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alex Wang <alexw at nicira.com>


commit 595ef8b10ad81c6033df53dfbfdb8c1b01f6de87
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=595ef8b10ad81c6033df53dfbfdb8c1b01f6de87
Author: Ben Pfaff <blp at nicira.com>
		
ovs-thread: Quiesce in xpthread_barrier_wait().
		
Otherwise the udpif revalidator threads can postpone RCU callbacks
essentially forever, especially if there are many revalidator threads and
little network traffic.

Reported-by: Alex Wang <alexw at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alex Wang <alexw at nicira.com>


commit 3308c696220bbfff36bf29b3e1b168449d57b3d7
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3308c696220bbfff36bf29b3e1b168449d57b3d7
Author: Ben Pfaff <blp at nicira.com>
		
timeval: Preserve quiescence across time_poll().
		
Otherwise ovsrcu_synchronize() busy-waits in its loop because its
poll_block() un-quiesces, causing the global_seqno to increase, which is
what it waits for.

Reported-by: Alex Wang <alexw at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alex Wang <alexw at nicira.com>


commit 1edc458d61d9846b743310d9dd37ad181b013e5f
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=1edc458d61d9846b743310d9dd37ad181b013e5f
Author: Joe Stringer <joestringer at nicira.com>
		
datapath: Check for backported skb_orphan_frags().
		
This was causing build failures on debian wheezy. Check for the feature
rather than the version.

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 NEWS                                         |    8 +++-
 acinclude.m4                                 |    1 +
 configure.ac                                 |    2 +-
 datapath/linux/compat/include/linux/skbuff.h |    4 +-
 debian/changelog                             |   29 +++++++++++--
 lib/dpif-netdev.c                            |    6 +--
 lib/lacp.c                                   |   18 ++++-----
 lib/netdev-dpdk.c                            |    4 +-
 lib/ovs-rcu.c                                |   34 ++++++++++++++--
 lib/ovs-rcu.h                                |    1 +
 lib/ovs-thread.c                             |   56 ++++++++++++++++++--------
 lib/ovs-thread.h                             |   15 +++----
 lib/timeval.c                                |   14 ++++---
 ofproto/ofproto-dpif-monitor.c               |    3 +-
 ofproto/ofproto-dpif-upcall.c                |   26 ++++--------
 tests/ofproto-dpif.at                        |    4 +-
 vswitchd/system-stats.c                      |    3 +-
 17 files changed, 149 insertions(+), 79 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list