[ovs-git] Open vSwitch: ofproto-dpif: Close race between processing packet_ins and checking seqno. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Apr 30 20:03:42 UTC 2014

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  b53d5c33bc91bdd2e46c67aec3af04a4dc020e26 (commit)
       via  f0a6bdc9f56a95157ca6ee3c1f763aed0e0dae08 (commit)
      from  6dc5374435cc25bc4051b27bd52635e609a8872a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b53d5c33bc91bdd2e46c67aec3af04a4dc020e26
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b53d5c33bc91bdd2e46c67aec3af04a4dc020e26
Author: Ben Pfaff <blp at nicira.com>
ofproto-dpif: Close race between processing packet_ins and checking seqno.
If a packet-in were to be queued, and the sequence number changed, after
grabbing the list of packet-ins, then the existing code could have gone to
sleep until something happened.  By grabbing the sequence number before
the list of packet-ins, we avoid this race.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at nicira.com>

commit f0a6bdc9f56a95157ca6ee3c1f763aed0e0dae08
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=f0a6bdc9f56a95157ca6ee3c1f763aed0e0dae08
Author: Pravin B Shelar <pshelar at nicira.com>
datapath: Remove unnecessary flow variable.
Patch fixes following warning:
datapath/linux/flow_table.c:580:40: warning: symbol 'flow' shadows an earlier one
datapath/linux/flow_table.c:558:24: originally declared here

Reported-by: Ben Pfaff <blp at nicira.com>
Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at nicira.com>


Summary of changes:
 datapath/flow_table.c  |    1 -
 ofproto/ofproto-dpif.c |   12 ++++++------
 2 files changed, 6 insertions(+), 7 deletions(-)

Open vSwitch

More information about the git mailing list