[ovs-git] [openvswitch/ovs] 107331: Add extentions to the standard datapath interface

Tue Aug 19 21:29:13 UTC 2014

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 107331906b32c606eddd3e0fc42b42d0a3bc7372
      https://github.com/openvswitch/ovs/commit/107331906b32c606eddd3e0fc42b42d0a3bc7372
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-08-19 (Tue, 19 Aug 2014)

  Changed paths:
    M build-aux/extract-odp-netlink-h
    M datapath-windows/automake.mk
    A datapath-windows/include/OvsDpInterfaceExt.h
    M datapath-windows/ovsext/ovsext.vcxproj

  Log Message:
  -----------
  Add extentions to the standard datapath interface

The datapath interface defined in odp-netlink.h needs some extensions
that are platform dependent. Some examples are the name of the communication
device on Windows and a set of commands that are specific to Windows.

In this change we define a datapath-windows/include/OvsDpInterfaceExt.h
to include any platform specific interface extensions.

OvsDpInterfaceExt.h is in turn included in odp-netlink.h ONLY for _WIN32.
This approach was chosen to avoid including OvsDpInterfaceExt.h directly
although the latter approach is as good as the former.

Also, we define three ioctls in OvsDpInterfaceExt.h:
read:     provides an output buffer (mimics a recv)
write:    provides an input buffer (mimics a send)
transact: provides an input and optionally an output buffer.
    (mimics a send followed by recv)

Signed-off-by: Nithin Raju <nithin at vmware.com>
Co-Authored-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alin Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 4f3988e0f6e3efcb418a3ba9de433970a64bfca4
      https://github.com/openvswitch/ovs/commit/4f3988e0f6e3efcb418a3ba9de433970a64bfca4
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-08-19 (Tue, 19 Aug 2014)

  Changed paths:
    M datapath-windows/automake.mk
    A datapath-windows/ovsext/Datapath.c
    A datapath-windows/ovsext/Datapath.h
    M datapath-windows/ovsext/OvsActions.c
    M datapath-windows/ovsext/OvsDebug.h
    M datapath-windows/ovsext/OvsDriver.c
    M datapath-windows/ovsext/OvsEvent.c
    M datapath-windows/ovsext/OvsFlow.c
    M datapath-windows/ovsext/OvsIoctl.c
    M datapath-windows/ovsext/OvsIoctl.h
    M datapath-windows/ovsext/OvsOid.c
    M datapath-windows/ovsext/OvsPacketIO.c
    M datapath-windows/ovsext/OvsSwitch.c
    M datapath-windows/ovsext/OvsTunnel.c
    M datapath-windows/ovsext/OvsUser.c
    M datapath-windows/ovsext/OvsVport.c
    M datapath-windows/ovsext/OvsVxlan.c
    M datapath-windows/ovsext/ovsext.vcxproj
    M datapath-windows/ovsext/precomp.h

  Log Message:
  -----------
  datapath-windows: Add Datapath.[ch] and OVS_USE_NL_INTERFACE CPP

In this change we create peer to OvsIoctl.[ch] that would interface
with userspace using the netlink interface. The new files are called
Datapath.[ch]. We are not deleting OvsIoctl.[ch] yet. Datapath.[ch]
provides bare minimum functionality to register a pseudo device for
communication with userspace.

We also define a CPP called OVS_USE_NL_INTERFACE in the ovsext project.
This defines if the old interface (pre-netlink based) or the new
interface (netlink- based) should be enabled in the kernel. By default,
the value is 0 since the Datapath.[ch] are minimal. In the next change,
we'll turn it to 1.

Since Datapath.[ch] containes code copied from OvsIoctl.[ch], acking
the original author as well.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Co-authored-by: Guolin Yang <gyang at vmware.com>
Acked-by: Alin Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 3b89ffba9cee84a12462f7374904f963d4d45aa8
      https://github.com/openvswitch/ovs/commit/3b89ffba9cee84a12462f7374904f963d4d45aa8
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-08-19 (Tue, 19 Aug 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Datapath.h
    M datapath-windows/ovsext/ovsext.vcxproj

  Log Message:
  -----------
  datapath-windows: add infrastructure for supporting netlink

In this change, we define netlink families and commands supported
by the Windows datapath. Only the control family and one command
is supported today to get the PID.

We also implement the 3 ioctls: read, write and transact. This is
bare minimum and can be used to implement the equivalent of a
recv, send, and send-recv in userspace netlink. This interface
is subject to change as iron out the details of the user-kernel
interface for operations around packet receive, events, dump, etc.

We also turn on OVS_USE_NL_INTERFACE to 1 in the ovsext project.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Alin Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/18
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 886dd35a03e9a412630c384975d71210983b12f2
      https://github.com/openvswitch/ovs/commit/886dd35a03e9a412630c384975d71210983b12f2
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-08-19 (Tue, 19 Aug 2014)

  Changed paths:
    M lib/netlink-socket.c

  Log Message:
  -----------
  netlink-socket.c: implement get pid support on Windows

To verify if the netlink support in the kernel works, I updated
the netlink-socket.c code to get the PID for a given device
descriptor.

In the existing code, userspace sets the PID, which will not be
unique across different processes. So, it is better for the
kernel to generate the PID and give it back to userspace.

dpif-linux.c was ported to Windows (similar to Alin's change in
the cloudbase repo) and was able to exercise the code changes
in netlink-socket.c to read the PID. dpif-linux.c changes are
not being checked in.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Alin Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/18
Signed-off-by: Ben Pfaff <blp at nicira.com>

Compare: https://github.com/openvswitch/ovs/compare/f7491dce43e5...886dd35a03e9