[ovs-git] Open vSwitch: rconn: Discover errors in rconn_run() even if rconn_recv() is never called. (master)

dev at openvswitch.org dev at openvswitch.org
Thu Feb 27 22:11:59 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  accaecc419cc57d9517f66d205ed90e83522f771 (commit)
      from  3b401f9baf4c0dd9e9eebb0a9f4417fdf3a80774 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit accaecc419cc57d9517f66d205ed90e83522f771
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=accaecc419cc57d9517f66d205ed90e83522f771
Author: Ben Pfaff <blp at nicira.com>
		
rconn: Discover errors in rconn_run() even if rconn_recv() is never called.
		
rconn_recv() calls vconn_recv(), which will report a connection error and
cause rconn_recv() to disconnect the rconn.  Most rconn users regularly
call rconn_recv(), so that disconnection happens promptly.  However,
the lswitch code only calls rconn_recv() after the connection negotiates an
OpenFlow version, so a connection that failed before negotiation would
never be detected as failed.  This commit fixes the problem by making
rconn_run() also detect and handle connection errors.

The lswitch code is only used by the test-controller program, so this is
not an important bug fix.

Reported-by: Vasu Dasari <vdasari at gmail.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/rconn.c |   10 +++++++++-
 lib/vconn.c |   11 ++++++++++-
 lib/vconn.h |    4 +++-
 3 files changed, 22 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list