[ovs-git] Open vSwitch: datapath: Correctly report flow used times for first 5 minutes after boot. (branch-2.1)

dev at openvswitch.org dev at openvswitch.org
Fri Feb 28 23:20:17 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-2.1 has been updated
       via  fc27bdc6ce5b6b3f95dbbc1ef5adbf3aa0e58e4a (commit)
      from  dff392b2bb40aa4ccd884bee43ac92fa501fb100 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fc27bdc6ce5b6b3f95dbbc1ef5adbf3aa0e58e4a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fc27bdc6ce5b6b3f95dbbc1ef5adbf3aa0e58e4a
Author: Ben Pfaff <blp at nicira.com>
		
datapath: Correctly report flow used times for first 5 minutes after boot.
		
The kernel starts out its "jiffies" timer as 5 minutes below zero, as
shown in include/linux/jiffies.h:

  /*
   * Have the 32 bit jiffies value wrap 5 minutes after boot
   * so jiffies wrap bugs show up earlier.
   */
  #define INITIAL_JIFFIES ((unsigned long)(unsigned int) (-300*HZ))

The loop in ovs_flow_stats_get() starts out with 'used' set to 0, then
takes any "later" time.  This means that for the first five minutes after
boot, flows will always be reported as never used, since 0 is greater than
any time already seen.

Bug #1192516.
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/flow.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list