[ovs-git] Open vSwitch: ofproto-dpif: Fix a vlan-splinter megaflow bug (master)

dev at openvswitch.org dev at openvswitch.org
Wed Jan 8 04:26:35 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  d02c42bf4d8ecb0723ca5c6a3156c480949344a4 (commit)
      from  fe68c005871ec5b4b3f33c1b99593667cc83c234 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d02c42bf4d8ecb0723ca5c6a3156c480949344a4
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=d02c42bf4d8ecb0723ca5c6a3156c480949344a4
Author: Andy Zhou <azhou at nicira.com>
		
ofproto-dpif: Fix a vlan-splinter megaflow bug
		
When vlan-splinter is enabled, ovs receives non-vlan flows from the
kernel vlan ports, vlan tag is then added to the incoming flow before
xlating, so that they look like those received from a trunk port.

In case megaflow is enabled, xlating may set vlan masks during rule
processing as usual. If those vlan masks were serialized and downloaded
to the kernel (this bug), those mega flows will be rejected due to
unexpected vlan mask encapsulation, since the original kernel flows do
not have vlan tags. This bug does not break connectivity, but impacts
performance since all traffic received on vlan splinter ports will now
be handled by vswitchd, as no datapath flows can be successfully
installed.

This fix is to make sure no vlan mask encapsulation is generated for
the datapath flow if its in_port was re-written by vlan-splinter
receiving logic.

Bug #22567

Signed-off-by: Andy Zhou <azhou at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto-dpif-upcall.c |   57 +++++++++++++++++++++++++++--------------
 1 file changed, 38 insertions(+), 19 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list