[ovs-git] Open vSwitch: datapath: Use exact lookup for flow_get and flow_del. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Jul 1 21:05:47 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  3440e4bc2f76fdbed6c49116744ded728eebeda1 (commit)
      from  09f27436b1fcab822ad358890b0e953b24c4a215 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3440e4bc2f76fdbed6c49116744ded728eebeda1
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3440e4bc2f76fdbed6c49116744ded728eebeda1
Author: Alex Wang <alexw at nicira.com>
		
datapath: Use exact lookup for flow_get and flow_del.
		
Due to the race condition in userspace, there is chance that two
overlapping megaflows could be installed in datapath.  And this
causes userspace unable to delete the less inclusive megaflow flow
even after it timeout, since the flow_del logic will stop at the
first match of masked flow.

This commit fixes the bug by making the kernel flow_del and flow_get
logic check all masks in that case.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>



-----------------------------------------------------------------------

Summary of changes:
 datapath/datapath.c   |   24 ++++++++++++------------
 datapath/flow_table.c |   25 ++++++++++++++++++++++++-
 datapath/flow_table.h |    2 ++
 3 files changed, 38 insertions(+), 13 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list