[ovs-git] Open vSwitch: dpif-linux: Recheck the socket pointer existence before getting its pid. (master)

dev at openvswitch.org dev at openvswitch.org
Tue Jul 8 06:04:05 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  17f2748d245e74249d46a590da0f7456ebb27e7c (commit)
      from  b44d9db7befde9498d2e655c9a5d8c16d6df8e6a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 17f2748d245e74249d46a590da0f7456ebb27e7c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=17f2748d245e74249d46a590da0f7456ebb27e7c
Author: Alex Wang <alexw at nicira.com>
		
dpif-linux: Recheck the socket pointer existence before getting its pid.
		
This commit fixes a race between port deletion and flow miss handling.
More specifically, a port could be removed by main thread while
the handler thread is handling the flow miss from it.  If the flow
requires slow path action, the handler thread will try querying a pid
from port's socket.  Since the port has been deleted, the query will
cause a dereference of NULL socket pointer.

This commit makes the handler thread recheck the socket pointer before
dereferencing it.

VMware-BZ: 1251981

Reported-by: Pratap Reddy <preddy at nicira.com>
Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Joe Stringer <joestringer at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/dpif-linux.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list