[ovs-git] Open vSwitch: daemon: restart child process if it died before signaling its readiness (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  b925336a36e6041b006d59ef78e91c5c13be62ba (commit)
      from  4537a423fb4c607fcbef53ab830e86250ba8748c (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit b925336a36e6041b006d59ef78e91c5c13be62ba
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=b925336a36e6041b006d59ef78e91c5c13be62ba
Author: Ansis Atteka <aatteka at nicira.com>
		
daemon: restart child process if it died before signaling its readiness
		
The child process (the one being monitored) could die before it was able
to call fork_notify_startup() function.  If such situation arises, then
parent process (the one monitoring child process) would also terminate
with a fatal log message:

...|EMER|fork child died before signaling startup (killed (...))

This patch changes that behavior by always restarting child process
if it was able to start up at least once in the past.  However, if
child was not able to start up even once, then the monitor process
would still terminate, because that would most likely indicate a
persistent programming or system error.

To reproduce use following script:

while : ; do kill -SIGSEGV `cat /var/run/openvswitch/ovs-vswitchd.pid`; done

Signed-Off-By: Ansis Atteka <aatteka at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>
VMware-BZ: 1273550


-----------------------------------------------------------------------

Summary of changes:
 lib/daemon-unix.c |   63 ++++++++++++++++++++++++++++++++++-------------------
 1 file changed, 41 insertions(+), 22 deletions(-)


hooks/post-receive
-- 
Open vSwitch