[ovs-git] Open vSwitch: datapath: refactor do_output() to move skb_clone NULL check out of fast path (master)

dev at openvswitch.org dev at openvswitch.org
Thu Jul 10 22:04:07 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  fe90efd9d69ad84c5086442b6400be9e92aa1e9e (commit)
       via  15cd5a8e1d4146334d670ab712dad66b46a81145 (commit)
       via  37dfe5264b7a832f9e447217585df68158881578 (commit)
      from  aa359b5f8b5c2e887a7b7d6434d04c7a04fe6d3d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit fe90efd9d69ad84c5086442b6400be9e92aa1e9e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=fe90efd9d69ad84c5086442b6400be9e92aa1e9e
Author: Andy Zhou <azhou at nicira.com>
		
datapath: refactor do_output() to move skb_clone NULL check out of fast path
		
skb_clone() NULL check is implemented in do_output(), as past of the
common (fast) path. Refactoring so that NULL check is done in the
slow path, immediately after skb_clone() is called.

Besides optimization, this change also improves code readability by
making the skb_clone() NULL check consistent within OVS datapath
module.

Signed-off-by: Andy Zhou <azhou at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>


commit 15cd5a8e1d4146334d670ab712dad66b46a81145
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15cd5a8e1d4146334d670ab712dad66b46a81145
Author: Andy Zhou <azhou at nicira.com>
		
datapath: add skb_clone NULL check for the sampling action.
		
Fix a bug where skb_clone() NULL check is missing in sample action
implementation.

Signed-off-by: Andy Zhou <azhou at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>


commit 37dfe5264b7a832f9e447217585df68158881578
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=37dfe5264b7a832f9e447217585df68158881578
Author: Andy Zhou <azhou at nicira.com>
		
datapath: add skb_clone NULL check in the recirc action.
		
Refactoring recirc action implementation.

The main change is to fix a bug where the NULL check after skb clone()
call is missing.  The fix is to return -ENOMEM whenever skb_clone()
failed to create a clone.

Also rearranged adjacent code to improve readability.

Reported-by: Pravin B Shelar <pshelar at nicira.com>
Signed-off-by: Andy Zhou <azhou at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/actions.c |   44 +++++++++++++++++++++++---------------------
 1 file changed, 23 insertions(+), 21 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list