[ovs-git] Open vSwitch: bridge: Make ovs-vswitchd run again if status_txn commit fails. (master)

dev at openvswitch.org dev at openvswitch.org
Sat Jun 14 01:04:17 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  15c9fbd8f28f907776db0f594a25ea94bf890978 (commit)
       via  8f5514fe7c3c2ba0d06405c1f75e08ae78e65ee9 (commit)
       via  685acfd9ff6679a0c6b4f3a53db6b633cf40472d (commit)
      from  d8043da7182aa0700e8e85a7c53929f3be054ef9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 15c9fbd8f28f907776db0f594a25ea94bf890978
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=15c9fbd8f28f907776db0f594a25ea94bf890978
Author: Alex Wang <alexw at nicira.com>
		
bridge: Make ovs-vswitchd run again if status_txn commit fails.
		
This commit adds logic that checks the return value of status_txn
transaction and runs the update again if the transaction fails
(transaction status is not 'TXN_SUCCESS', 'TXN_UNCHANGED', or
'TXN_INCOMPLETE').

To keep the code simple, the re-run of update on transaction failure
will extracts the status from all interfaces, rather than just those
that have status change.  Since the transaction failure is considered
to be very rare, such overhead is deemed to be affordable.

VMware-BZ: 1256577

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 8f5514fe7c3c2ba0d06405c1f75e08ae78e65ee9
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8f5514fe7c3c2ba0d06405c1f75e08ae78e65ee9
Author: Alex Wang <alexw at nicira.com>
		
ofproto: Add separate functions for checking bfd/cfm status change.
		
Currently, ofproto_port_get_bfd/cfm_status() is used to check the
bfd/cfm status change and query the status change.  Users decide
what to do with the filled status struct based on the return value
of the funciton.  Such design is confusing and makes the caller
code hard to read.

This commit breaks the function into a status change check function
and a status query function, so that they become easier to read and
use.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 685acfd9ff6679a0c6b4f3a53db6b633cf40472d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=685acfd9ff6679a0c6b4f3a53db6b633cf40472d
Author: Alex Wang <alexw at nicira.com>
		
cfm: Extracts the cfm status in one function.
		
This commit adds a new function, cfm_get_status(), for extracting
all cfm status at once.  This helps avoid the sequence of lock
acquire/release in current implementation of status query.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/cfm.c                  |   42 +++++++++++++++++++++++++------
 lib/cfm.h                  |   24 ++++++++++++++++++
 ofproto/ofproto-dpif.c     |   39 +++++++++++++++-------------
 ofproto/ofproto-provider.h |   27 ++++++++++----------
 ofproto/ofproto.c          |   34 ++++++++++++++++++++-----
 ofproto/ofproto.h          |   26 +++----------------
 vswitchd/bridge.c          |   60 +++++++++++++++++++++++++++++++-------------
 7 files changed, 167 insertions(+), 85 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list