[ovs-git] Open vSwitch: atlocal: Disable Python related tests on Windows. (master)

[dev at openvswitch.org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  0f1e8ed05d8f9c4658c0a11c3538eae5c804cf97 (commit)
       via  7acb0553ce4d14a235e82635a5c5f1345dd3c7bf (commit)
       via  3c1150cecf39f463882ebbf0c071a7a097fa95b0 (commit)
       via  02a514ef712534b53ca315bf9c7b091229425076 (commit)
       via  784acd821b8f4e4be12e91d4d80b15880c297a7d (commit)
       via  64559798f85900cbacd6abd76accc5d17a206bef (commit)
      from  c354fcc575718928224612f135b231f7e1584c2a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 0f1e8ed05d8f9c4658c0a11c3538eae5c804cf97
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0f1e8ed05d8f9c4658c0a11c3538eae5c804cf97
Author: Gurucharan Shetty <gshetty at nicira.com>
		
atlocal: Disable Python related tests on Windows.
		
Most of the Python code in Open vSwitch repo does not work
on Windows. Till that porting is done, simply skip all
Python tests.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 7acb0553ce4d14a235e82635a5c5f1345dd3c7bf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7acb0553ce4d14a235e82635a5c5f1345dd3c7bf
Author: Gurucharan Shetty <gshetty at nicira.com>
		
lockfile: Modify tests for Windows.
		
As of now, when a process tries to reacquire a lockfile, we
return EEXIST on Windows and print a different error message.
This means that the unit tests need to look for different error
messages too. Linux uses EDEADLK for the same. EDEADLK feels like
a good error description for Windows too and this also lets us
not change the tests too much. So use it.

Some of the tests in test-lockfile.c uses fork to test a
child's ability to acquire lock. We do not fork in Windows.
We also do not support symlinks on Windows.  So, comment out
those tests.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 3c1150cecf39f463882ebbf0c071a7a097fa95b0
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3c1150cecf39f463882ebbf0c071a7a097fa95b0
Author: Gurucharan Shetty <gshetty at nicira.com>
		
util: Don't compile couple of unused function for Windows.
		
basename() and dir_name() are not used for Windows and won't work well if
used. So put a '#ifndef _WIN32' around them to prevent future calls.

test-file_name.c tests the above 2 functions. It makes sense to merge
this single function file with test-util.c and then not compile it for
Windows.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 02a514ef712534b53ca315bf9c7b091229425076
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=02a514ef712534b53ca315bf9c7b091229425076
Author: Gurucharan Shetty <gshetty at nicira.com>
		
daemon-windows: unlink pidfile before stopping the service.
		
When a OVS daemon is configured to run as a Windows service,
when the service is stopped by calling service_stop(), the
windows services manager does not give enough time to do
everything in the atexit handler. So call the exit handler
directly from service_stop().

Also add a test case for Windows services which checks for
the termination of the service by looking at pidfile cleaned
by the exit handler.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com
Acked-by: Ben Pfaff <blp at nicira.com>


commit 784acd821b8f4e4be12e91d4d80b15880c297a7d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=784acd821b8f4e4be12e91d4d80b15880c297a7d
Author: Gurucharan Shetty <gshetty at nicira.com>
		
test-util: Changes for 'assert' test on Windows.
		
There is no 'kill -l' type functionality available on Windows.
So instead of looking for the string 'ABRT', check for the exit
code in both platforms. On msys (unit test environment), it is 9
and on Linux, it is 134 (SIGABRT + 128).

On Windows, stderr is fully buffered if connected to a pipe.
Make it _IONBF so that an abort does not miss log contents.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 64559798f85900cbacd6abd76accc5d17a206bef
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=64559798f85900cbacd6abd76accc5d17a206bef
Author: Gurucharan Shetty <gshetty at nicira.com>
		
util: Make WSAStartup available outside stream.c.
		
WSAStartup() needs to be called before using winsock2 related
functions. We need this for almost all the utilities. So call
it through OVS_CONSTRUCTOR.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/daemon-windows.c   |    5 +++++
 lib/fatal-signal.c     |    7 +++----
 lib/fatal-signal.h     |    1 +
 lib/lockfile.c         |    5 +++--
 lib/stream.c           |   29 ---------------------------
 lib/util.c             |   13 ++++++++++++
 lib/util.h             |    2 ++
 tests/.gitignore       |    1 -
 tests/atlocal.in       |    7 +++++++
 tests/automake.mk      |    2 --
 tests/daemon.at        |   25 ++++++++++++++++++++++++
 tests/file_name.at     |    3 ++-
 tests/library.at       |   11 ++++++++---
 tests/lockfile.at      |   13 +++++++-----
 tests/test-file_name.c |   40 -------------------------------------
 tests/test-lockfile.c  |   51 +++++++++++++++++++++++++++---------------------
 tests/test-util.c      |   28 ++++++++++++++++++++++++++
 17 files changed, 134 insertions(+), 109 deletions(-)
 delete mode 100644 tests/test-file_name.c


hooks/post-receive
-- 
Open vSwitch