[ovs-git] Open vSwitch: datapath: Rehash 16-bit skbuff hashes into 32 bits. (master)

dev at openvswitch.org dev at openvswitch.org
Wed Jun 25 16:04:14 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  5640cbd8bd18b1f7963a219ce9ae91d8a830ad5a (commit)
      from  210ba964f5c6ed0a4696fd16344475a31c313823 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5640cbd8bd18b1f7963a219ce9ae91d8a830ad5a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=5640cbd8bd18b1f7963a219ce9ae91d8a830ad5a
Author: Jesse Gross <jesse at nicira.com>
		
datapath: Rehash 16-bit skbuff hashes into 32 bits.
		
Currently, if the network stack provides skb->rxhash then we use it,
otherwise we compute our own. However, on at least some versions of
RHEL/CentOS, the stack provides a hash that is 16 bits rather than
32 bits. In cases where we use the uppermost bits of the hash this
is particularly bad because we detect that a hash is present and we
use it rather than computing our own but the result is always zero.

This is particularly noticible with tunnel ports that use the hash
to generate a source port, such as VXLAN. On these kernels the tunnel
source port is always the minimum value. To solve this problem while
still taking advantage of the precomputed hash, this rehashes the
hash so that the entropy is spread throughout 32 bits.

Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Thomas Graf <tgraf at noironetworks.com>


-----------------------------------------------------------------------

Summary of changes:
 acinclude.m4                                 |    2 ++
 datapath/linux/compat/include/linux/skbuff.h |    5 +++++
 2 files changed, 7 insertions(+)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list