[ovs-git] Open vSwitch: odp-util: Include tun_id when nonzero even if "key" flag not set. (branch-1.11)

dev at openvswitch.org dev at openvswitch.org
Mon Mar 3 20:56:07 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, branch-1.11 has been updated
       via  8d0131e0874d4b5544e062ad19d3aad1132dc5e6 (commit)
      from  6906a7d1f303b8b22480db39736a456e8ecffead (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8d0131e0874d4b5544e062ad19d3aad1132dc5e6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=8d0131e0874d4b5544e062ad19d3aad1132dc5e6
Author: Ben Pfaff <blp at nicira.com>
		
odp-util: Include tun_id when nonzero even if "key" flag not set.
		
When a flow_tnl is being translated to Netlink attributes, the tun_id field
was included only if the FLOW_TNL_F_KEY flag was set.  This meant that for
a mask, where one would not necessarily expect that flag to be set even if
there were a key, the tun_id could be omitted even if it were nonzero.
This led to kernel flows that did not match on a field that was required
to be matched (possibly causing incorrect treatment of packets) and
premature deletion of kernel flows due to mask mismatch.  This commit
fixes the problem.

Bug #1192516.
Reported-by: Krishna Miriyala <miriyalak at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/odp-util.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list