[ovs-git] Open vSwitch: ofproto: Fix is_flow_deletion_pending() false positive. (master)

dev at openvswitch.org dev at openvswitch.org
Thu May 1 20:03:51 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  a6fcf462476db3385027d3bfcc1d2dc8386e6f2a (commit)
       via  0ef165ecb57943e17a8ee8270df68ffb8d032e29 (commit)
       via  25d6a6a8803761cf321ba45d1eeb6df29c2a6c6e (commit)
      from  e38785b39dc172d02bd2ae7db1a45a16e5517146 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a6fcf462476db3385027d3bfcc1d2dc8386e6f2a
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=a6fcf462476db3385027d3bfcc1d2dc8386e6f2a
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto: Fix is_flow_deletion_pending() false positive.
		
If one tries to install a rule that's identical to another rule in
another OpenFlow table which is being deleted, it's possible that
is_flow_deletion_pending() might confuse them and block the
installation.  This is such an edge case I doubt it has ever actually
happened.

Found by inspection.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 0ef165ecb57943e17a8ee8270df68ffb8d032e29
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=0ef165ecb57943e17a8ee8270df68ffb8d032e29
Author: Ethan Jackson <ethan at nicira.com>
		
ofproto: Fix potential leak during flow mods.
		
This code created a cls_rule without destroying it.  Found by
inspection.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


commit 25d6a6a8803761cf321ba45d1eeb6df29c2a6c6e
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=25d6a6a8803761cf321ba45d1eeb6df29c2a6c6e
Author: Simon Horman <horms at verge.net.au>
		
ofproto-dpif: Make bonding balance test more robust
		
It is my observation that when sending 91 packets to a mode=balance
bond interface with three underlying ports in some cases not all ports
receive at least 7 packets. This causes the test to fail.

It may be that failure indicates that the bonding code
needs improvement. But it seems to me that its more likely to
be a valid behaviour.

I have found that by sending 256 packets instead of 91 the test passes
more reliably: I am yet to see it fail.

Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Andy Zhou <azhou at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 ofproto/ofproto.c     |   10 +++++-----
 tests/ofproto-dpif.at |    2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list