[ovs-git] Open vSwitch: test-ovsdb: Fix setvbuf incompatibility on Windows. (master)

dev at openvswitch.org dev at openvswitch.org
Wed May 14 22:04:08 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  76a6e6309c2d8a7d3df16b531a584598c0bc3b04 (commit)
       via  cf1e5c18c50c7c5cb7c50b2ad839e39865daf206 (commit)
       via  144ccc021ec9d43cb92625b6ee4714779c626ccf (commit)
       via  7882cfb1e3795dde70c18eaee754506cbcb38a5d (commit)
       via  af32ce7a8253c663feaa3305d885788fbaac4ea6 (commit)
       via  2b89438deb343d2e572efb27bd0e1028f34f5adc (commit)
       via  3e94784cb7202847ecde47e389a377ff0003c285 (commit)
      from  52ca734e820d6b183aba5ca1c7d714f3c7e7a781 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 76a6e6309c2d8a7d3df16b531a584598c0bc3b04
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=76a6e6309c2d8a7d3df16b531a584598c0bc3b04
Author: Gurucharan Shetty <gshetty at nicira.com>
		
test-ovsdb: Fix setvbuf incompatibility on Windows.
		
setvbuf() in Windows treats _IOLBF to be the same as _IOFBF. So
we cannot have size as zero (otherwise, there is a crash).

Workaround is to set _IONBF. I don't see unit test failures
because of the change.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit cf1e5c18c50c7c5cb7c50b2ad839e39865daf206
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=cf1e5c18c50c7c5cb7c50b2ad839e39865daf206
Author: Gurucharan Shetty <gshetty at nicira.com>
		
util: set_program_name() can be called twice with different names.
		
Ex: ovstest.c

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 144ccc021ec9d43cb92625b6ee4714779c626ccf
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=144ccc021ec9d43cb92625b6ee4714779c626ccf
Author: Gurucharan Shetty <gshetty at nicira.com>
		
util: Disable popups while asserting in windows.
		
The default behavior for programs is to display a popup
after an assert/abort etc. This is not an ideal behavior because
this needs user intervention.

set_program_name, though not an ideal place to disable this, is
a useful place because it is called by all programs including
unit test binaries.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 7882cfb1e3795dde70c18eaee754506cbcb38a5d
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=7882cfb1e3795dde70c18eaee754506cbcb38a5d
Author: Gurucharan Shetty <gshetty at nicira.com>
		
tests/library.at: Disable unix socket tests on Windows.
		
Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit af32ce7a8253c663feaa3305d885788fbaac4ea6
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=af32ce7a8253c663feaa3305d885788fbaac4ea6
Author: Gurucharan Shetty <gshetty at nicira.com>
		
ovs-pki: Pass correct argument to 'sign' command.
		
The first argument passed to 'sign' command is used as prefix
for both req.pem and cert.pem.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


commit 2b89438deb343d2e572efb27bd0e1028f34f5adc
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=2b89438deb343d2e572efb27bd0e1028f34f5adc
Author: Gurucharan Shetty <gshetty at nicira.com>
		
timeval: Workaround strftime bug in VS 2013.
		
Visual Studio 2013's behavior is to crash when 0 is passed as second
argument to strftime.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>


commit 3e94784cb7202847ecde47e389a377ff0003c285
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=3e94784cb7202847ecde47e389a377ff0003c285
Author: Gurucharan Shetty <gshetty at nicira.com>
		
ovsdb: Open database in binary mode.
		
Some ovsdb-tool related unit tests fail with bad checksum errors
while reading transactions from database. It is most likely because
of the CR at the end of line. Using binary mode solves the problem.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 lib/timeval.c        |    4 +++-
 lib/util.c           |    4 +++-
 ovsdb/log.c          |    3 +++
 tests/automake.mk    |    7 ++++++-
 tests/library.at     |    6 ++++--
 tests/test-ovsdb.c   |    2 +-
 utilities/ovs-pki.in |    2 +-
 7 files changed, 21 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list