[ovs-git] Open vSwitch: datapath: 16bit inner_network_header field in struct ovs_gso_cb (master)

dev at openvswitch.org dev at openvswitch.org
Wed May 21 01:04:37 UTC 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Open vSwitch".

The branch, master has been updated
       via  e262505ce4b908307441478a9b65e1bb22760e0c (commit)
      from  0e6661604066cabc41d6a43ac7761eefab746a53 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e262505ce4b908307441478a9b65e1bb22760e0c
Diffs: http://openvswitch.org/cgi-bin/gitweb.cgi?p=openvswitch;a=commitdiff;h=e262505ce4b908307441478a9b65e1bb22760e0c
Author: Simon Horman <horms at verge.net.au>
		
datapath: 16bit inner_network_header field in struct ovs_gso_cb
		
The motivation for this is to create a 16bit hole in struct ovs_gso_cb
which may be used for the inner_protocol field which is needed
for the proposed implementation of compatibility for MPLS GSO segmentation.

This should be safe as inner_network_header is now an offset to
the inner_mac_header rather than skb->head.

As pointed out by Thomas Graf simply making both inner offsets 16bis is not
safe as there have been cases of overflow with "with collapsed TCP frames
on IB when the headroom grew beyond 64K. See commit 50bceae9bd ``tcp:
Reallocate headroom if it would overflow csum_start'' for additional
details."

This patch is based on suggestions by Thomas Graf and Jesse Gross.

Cc: Thomas Graf <tgraf at suug.ch>
Cc: Jesse Gross <jesse at nicira.com>
Signed-off-by: Simon Horman <horms at verge.net.au>
Signed-off-by: Jesse Gross <jesse at nicira.com>


-----------------------------------------------------------------------

Summary of changes:
 datapath/linux/compat/gso.h |   28 +++++++++++++---------------
 1 file changed, 13 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
Open vSwitch



More information about the git mailing list